Skip to content

Commit e315337

Browse files
committed
chore: isolate code from x/tools
1 parent 904d637 commit e315337

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

pkg/goanalysis/runner_action.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -236,14 +236,6 @@ func (act *action) importPackageFact(pkg *types.Package, ptr analysis.Fact) bool
236236
return false
237237
}
238238

239-
// exportPackageFact implements Pass.ExportPackageFact.
240-
func (act *action) exportPackageFact(fact analysis.Fact) {
241-
key := packageFactKey{act.pass.Pkg, act.factType(fact)}
242-
act.packageFacts[key] = fact // clobber any existing entry
243-
factsDebugf("%s: package %s has fact %s\n",
244-
act.pkg.Fset.Position(act.pass.Files[0].Pos()), act.pass.Pkg.Path(), fact)
245-
}
246-
247239
func (act *action) markDepsForAnalyzingSource() {
248240
// Horizontal deps (analyzer.Requires) must be loaded from source and analyzed before analyzing
249241
// this action.

pkg/goanalysis/runner_base.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,15 @@ import (
1313
"golang.org/x/tools/go/analysis"
1414
)
1515

16+
// NOTE(ldez) altered: removes code related to `act.pass.ExportPackageFact`; logger; act.factType.
17+
// exportPackageFact implements Pass.ExportPackageFact.
18+
func (act *action) exportPackageFact(fact analysis.Fact) {
19+
key := packageFactKey{act.pass.Pkg, act.factType(fact)}
20+
act.packageFacts[key] = fact // clobber any existing entry
21+
factsDebugf("%s: package %s has fact %s\n",
22+
act.pkg.Fset.Position(act.pass.Files[0].Pos()), act.pass.Pkg.Path(), fact)
23+
}
24+
1625
// NOTE(ldez) altered: add receiver to handle logs.
1726
func (act *action) factType(fact analysis.Fact) reflect.Type {
1827
t := reflect.TypeOf(fact)

0 commit comments

Comments
 (0)