chore: groups goconst files to a package

Author: ldez

pkg/golinters/goconst.go renamed to pkg/golinters/goconst/goconst.go

@@ -1,4 +1,4 @@
-package golinters
+package goconst
 
 import (
 	"fmt"
@@ -14,14 +14,14 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-const goconstName = "goconst"
+const name = "goconst"
 
-func NewGoconst(settings *config.GoConstSettings) *goanalysis.Linter {
+func New(settings *config.GoConstSettings) *goanalysis.Linter {
 	var mu sync.Mutex
 	var resIssues []goanalysis.Issue
 
 	analyzer := &analysis.Analyzer{
-		Name: goconstName,
+		Name: name,
 		Doc:  goanalysis.TheOnlyanalyzerDoc,
 		Run: func(pass *analysis.Pass) (any, error) {
 			issues, err := runGoconst(pass, settings)
@@ -42,7 +42,7 @@ func NewGoconst(settings *config.GoConstSettings) *goanalysis.Linter {
 	}
 
 	return goanalysis.NewLinter(
-		goconstName,
+		name,
 		"Finds repeated strings that could be replaced by a constant",
 		[]*analysis.Analyzer{analyzer},
 		nil,
@@ -90,7 +90,7 @@ func runGoconst(pass *analysis.Pass, settings *config.GoConstSettings) ([]goanal
 		res = append(res, goanalysis.NewIssue(&result.Issue{
 			Pos:        i.Pos,
 			Text:       text,
-			FromLinter: goconstName,
+			FromLinter: name,
 		}, pass))
 	}
 

pkg/golinters/goconst/goconst_integration_test.go

@@ -0,0 +1,11 @@
+package goconst
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

test/testdata/goconst.go renamed to pkg/golinters/goconst/testdata/goconst.go

@@ -1,5 +1,5 @@
 //golangcitest:args -Egoconst
-//golangcitest:config_path testdata/configs/goconst_calls_enabled.yml
+//golangcitest:config_path testdata/goconst_calls_enabled.yml
 package testdata
 
 import "fmt"

test/testdata/goconst_calls_enabled.go renamed to pkg/golinters/goconst/testdata/goconst_calls_enabled.go

@@ -1,5 +1,5 @@
 //golangcitest:args -Egoconst
-//golangcitest:config_path testdata/configs/goconst_dont_ignore.yml
+//golangcitest:config_path testdata/goconst_dont_ignore.yml
 package testdata
 
 import (

test/testdata/configs/goconst_calls_enabled.yml renamed to pkg/golinters/goconst/testdata/goconst_calls_enabled.yml

@@ -1,5 +1,5 @@
 //golangcitest:args -Egoconst
-//golangcitest:config_path testdata/configs/goconst_ignore.yml
+//golangcitest:config_path testdata/goconst_ignore.yml
 //golangcitest:expected_exitcode 0
 package testdata
 

test/testdata/configs/goconst_dont_ignore.yml renamed to pkg/golinters/goconst/testdata/goconst_dont_ignore.yml

@@ -37,6 +37,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/gochecknoinits"
 	"github.com/golangci/golangci-lint/pkg/golinters/gochecksumtype"
 	"github.com/golangci/golangci-lint/pkg/golinters/gocognit"
+	"github.com/golangci/golangci-lint/pkg/golinters/goconst"
 	"github.com/golangci/golangci-lint/pkg/golinters/gocritic"
 	"github.com/golangci/golangci-lint/pkg/golinters/godot"
 	"github.com/golangci/golangci-lint/pkg/golinters/gofmt"
@@ -281,7 +282,7 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithPresets(linter.PresetComplexity).
 			WithURL("https://github.com/uudashr/gocognit"),
 
-		linter.NewConfig(golinters.NewGoconst(&cfg.LintersSettings.Goconst)).
+		linter.NewConfig(goconst.New(&cfg.LintersSettings.Goconst)).
 			WithSince("v1.0.0").
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/jgautheron/goconst"),