Skip to content

Commit ff11340

Browse files
committed
chore: windows you are not my friend
1 parent afb5317 commit ff11340

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

pkg/golinters/goconst/goconst.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package goconst
22

33
import (
44
"fmt"
5-
"path/filepath"
65
"sync"
76

87
goconstAPI "github.com/jgautheron/goconst"
@@ -101,7 +100,7 @@ func runGoconst(pass *analysis.Pass, settings *config.GoConstSettings) ([]goanal
101100
case issue.DuplicateConst != "":
102101
text = fmt.Sprintf("This constant is a duplicate of %s at %s",
103102
internal.FormatCode(issue.DuplicateConst, nil),
104-
filepath.ToSlash(issue.DuplicatePos.String()))
103+
issue.DuplicatePos.String())
105104

106105
default:
107106
continue

pkg/golinters/goconst/testdata/goconst_eval_and_find_duplicates.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ const (
1010
EnvPassword = envPrefix + "PASSWORD"
1111
)
1212

13-
const EnvUserFull = "FOO_USER" // want "This constant is a duplicate of `EnvUser` at goconst_eval_and_find_duplicates.go:9:16"
13+
const EnvUserFull = "FOO_USER" // want "This constant is a duplicate of `EnvUser` at .*goconst_eval_and_find_duplicates.go:9:16"
1414

1515
const KiB = 1 << 10
1616

1717
func _() {
1818
fmt.Println(envPrefix, EnvUser, EnvPassword, EnvUserFull)
1919

20-
const kilobytes = 1024 // want "This constant is a duplicate of `KiB` at goconst_eval_and_find_duplicates.go:15:13"
20+
const kilobytes = 1024 // want "This constant is a duplicate of `KiB` at .*goconst_eval_and_find_duplicates.go:15:13"
2121
fmt.Println(kilobytes)
2222

2323
kib := 1024

pkg/golinters/goconst/testdata/goconst_find_duplicates.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ const (
1111

1212
const (
1313
GroupedDuplicateConst1 = "grouped duplicate value"
14-
GroupedDuplicateConst2 = "grouped duplicate value" // want "This constant is a duplicate of `GroupedDuplicateConst1` at goconst_find_duplicates.go:13:2"
14+
GroupedDuplicateConst2 = "grouped duplicate value" // want "This constant is a duplicate of `GroupedDuplicateConst1` at .*goconst_find_duplicates.go:13:2"
1515
)
1616

1717
const DuplicateConst1 = "duplicate value"
1818

19-
const DuplicateConst2 = "duplicate value" // want "This constant is a duplicate of `DuplicateConst1` at goconst_find_duplicates.go:17:7"
19+
const DuplicateConst2 = "duplicate value" // want "This constant is a duplicate of `DuplicateConst1` at .*goconst_find_duplicates.go:17:7"
2020

2121
const (
2222
SpecialDuplicateConst1 = "special\nvalue\twith\rchars"
23-
SpecialDuplicateConst2 = "special\nvalue\twith\rchars" // want "This constant is a duplicate of `SpecialDuplicateConst1` at goconst_find_duplicates.go:22:2"
23+
SpecialDuplicateConst2 = "special\nvalue\twith\rchars" // want "This constant is a duplicate of `SpecialDuplicateConst1` at .*goconst_find_duplicates.go:22:2"
2424
)
2525

2626
func _() {
2727
const DuplicateScopedConst1 = "duplicate scoped value"
28-
const DuplicateScopedConst2 = "duplicate scoped value" // want "This constant is a duplicate of `DuplicateScopedConst1` at goconst_find_duplicates.go:27:8"
28+
const DuplicateScopedConst2 = "duplicate scoped value" // want "This constant is a duplicate of `DuplicateScopedConst1` at .*goconst_find_duplicates.go:27:8"
2929
}

0 commit comments

Comments
 (0)