Skip to content

Commit 426c325

Browse files
Fix syntax bug in readme file
The code sample type was changed and js and json syntax bugs were fixed
1 parent 7f27611 commit 426c325

File tree

1 file changed

+14
-18
lines changed

1 file changed

+14
-18
lines changed

readme.md

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,6 @@ beforeEach(() => {
11201120

11211121
• Observability - Some things must be monitored, like errors or remarkable business events. When a transaction fails, not only we expect the right response but also correct error handling and proper logging/metrics. This information goes directly to a very important user - The ops user (i.e., production SRE/admin)
11221122

1123-
</details>
11241123

11251124
<br/><br/>
11261125

@@ -1502,14 +1501,13 @@ before(() => {
15021501
})
15031502

15041503
// happens before EACH test
1505-
beforeEach(setUser => () {
1506-
cy.visit('/home', {
1507-
onBeforeLoad (win) {
1504+
beforeEach(setUser => {
1505+
cy.visit('/home', () => {
1506+
onBeforeLoad (win => {
15081507
win.localStorage.setItem('token', JSON.stringify(authenticationToken))
1509-
},
1508+
})
15101509
})
15111510
})
1512-
15131511
```
15141512

15151513
</details>
@@ -1567,8 +1565,8 @@ it("When doing smoke testing over all page, should load them all successfully",
15671565

15681566
![](https://img.shields.io/badge/🔨%20Example%20using%20Cucumber-blue.svg "Examples using Cucumber")
15691567

1570-
```javascript
1571-
// this is how one can describe tests using cucumber: plain language that allows anyone to understand and collaborate
1568+
```text
1569+
This is how one can describe tests using cucumber: plain language that allows anyone to understand and collaborate
15721570
15731571
Feature: Twitter new tweet
15741572
@@ -1581,7 +1579,6 @@ Feature: Twitter new tweet
15811579
Given I type "Hello followers!" in the textbox
15821580
Given I click on "Submit" button
15831581
Then I see message "Tweet saved"
1584-
15851582
```
15861583

15871584
### :clap: Doing It Right Example: Visualizing our components, their various states and inputs using Storybook
@@ -1803,7 +1800,7 @@ it.skip("Test name", () => {// *error:no-skipped-tests, error:error:no-global-te
18031800
expect("somevalue"); // error:no-assert
18041801
});
18051802

1806-
it("Test name", () => {*//error:no-identical-title. Assign unique titles to tests
1803+
it("Test name", () => {// *error:no-identical-title. Assign unique titles to tests
18071804
});
18081805
```
18091806

@@ -1853,23 +1850,23 @@ Practically, some CI vendors (Example: [CircleCI local CLI](https://circleci.com
18531850

18541851
### :clap: Doing It Right Example: npm scripts that perform code quality inspection, all are run in parallel on demand or when a developer is trying to push new code
18551852

1856-
```javascript
1857-
"scripts": {
1853+
```json
1854+
{
1855+
"scripts": {
18581856
"inspect:sanity-testing": "mocha **/**--test.js --grep \"sanity\"",
18591857
"inspect:lint": "eslint .",
18601858
"inspect:vulnerabilities": "npm audit",
18611859
"inspect:license": "license-checker --failOn GPLv2",
18621860
"inspect:complexity": "plato .",
1863-
18641861
"inspect:all": "concurrently -c \"bgBlue.bold,bgMagenta.bold,yellow\" \"npm:inspect:quick-testing\" \"npm:inspect:lint\" \"npm:inspect:vulnerabilities\" \"npm:inspect:license\""
18651862
},
18661863
"husky": {
18671864
"hooks": {
18681865
"precommit": "npm run inspect:all",
18691866
"prepush": "npm run inspect:all"
18701867
}
1868+
}
18711869
}
1872-
18731870
```
18741871

18751872
</details>
@@ -1933,13 +1930,12 @@ The huge Kubernetes ecosystem is yet to formalize a standard convenient tool for
19331930

19341931
### :clap: Doing It Right Example:
19351932

1936-
```javascript
1937-
//install license-checker in your CI environment or also locally
1933+
```shell
1934+
# install license-checker in your CI environment or also locally
19381935
npm install -g license-checker
19391936

1940-
//ask it to scan all licenses and fail with exit code other than 0 if it found unauthorized license. The CI system should catch this failure and stop the build
1937+
# ask it to scan all licenses and fail with exit code other than 0 if it found unauthorized license. The CI system should catch this failure and stop the build
19411938
license-checker --summary --failOn BSD
1942-
19431939
```
19441940

19451941
<br/>

0 commit comments

Comments
 (0)