agent-first-config: local agent config during component creation (#2840)

* agent-first-config: local agent config during component creation

* wip

* add tests

* update

* add diffing

Author: mschuwalow

cli/golem-cli/src/bridge_gen/rust/tests.rs

@@ -130,6 +130,7 @@ fn rust_counter_agent() -> GeneratedPackage {
         mode: AgentMode::Durable,
         http_mount: None,
         snapshotting: Snapshotting::Disabled(Empty {}),
+        config: Vec::new(),
     };
 
     GeneratedPackage::new(agent_type)

cli/golem-cli/src/bridge_gen/typescript/tests.rs

@@ -203,6 +203,7 @@ fn ts_counter_agent() -> GeneratedPackage {
         mode: AgentMode::Durable,
         http_mount: None,
         snapshotting: Snapshotting::Disabled(Empty {}),
+        config: Vec::new(),
     };
 
     GeneratedPackage::new(agent_type)

cli/golem-cli/src/command_handler/app/deploy_diff.rs

@@ -742,6 +742,9 @@ fn normalized_diff_deployment(
                             wasm_hash: component.wasm_hash,
                             files_by_path: component.files_by_path.clone(),
                             plugins_by_grant_id: component.plugins_by_grant_id.clone(),
+                            local_agent_config_ordered_by_agent_and_key: component
+                                .local_agent_config_ordered_by_agent_and_key
+                                .clone(),
                         }
                         .into(),
                         None => component.hash().into(),

cli/golem-cli/src/command_handler/component/mod.rs

@@ -1026,6 +1026,8 @@ impl ComponentCommandHandler {
             wasm_hash: component_binary_hash.into(),
             files_by_path,
             plugins_by_grant_id,
+            // FIXME: agent-config
+            local_agent_config_ordered_by_agent_and_key: Vec::new(),
         })
     }
 
@@ -1072,6 +1074,8 @@ impl ComponentCommandHandler {
                         .unwrap_or_default(),
                     env: component_stager.env(),
                     config_vars: component_stager.config_vars(),
+                    // FIXME: agent-config
+                    local_agent_config: Vec::new(),
                     agent_types,
                     plugins: component_stager.plugins(),
                 },
@@ -1166,6 +1170,8 @@ impl ComponentCommandHandler {
                     removed_files: changed_files.removed.clone(),
                     new_file_options: changed_files.merged_file_options(),
                     config_vars: component_stager.config_vars_if_changed(),
+                    // FIXME: local-agent-config
+                    local_agent_config: None,
                     env: component_stager.env_if_changed(),
                     agent_types,
                     plugin_updates: component_stager.plugins_if_changed(),

cli/golem-cli/src/model/agent/test.rs

@@ -101,6 +101,7 @@ pub fn single_agent_wrapper_types() -> Vec<AgentType> {
         mode: AgentMode::Durable,
         http_mount: None,
         snapshotting: Snapshotting::Disabled(Empty {}),
+        config: Vec::new(),
     }]
 }
 
@@ -172,6 +173,7 @@ pub fn multi_agent_wrapper_2_types() -> Vec<AgentType> {
             mode: AgentMode::Durable,
             http_mount: None,
             snapshotting: Snapshotting::Disabled(Empty {}),
+            config: Vec::new(),
         },
         AgentType {
             type_name: golem_common::model::agent::AgentTypeName("agent2".to_string()),
@@ -232,6 +234,7 @@ pub fn multi_agent_wrapper_2_types() -> Vec<AgentType> {
             mode: AgentMode::Durable,
             http_mount: None,
             snapshotting: Snapshotting::Disabled(Empty {}),
+            config: Vec::new(),
         },
     ];
 

cli/golem-cli/test-data/goldenfiles/extracted-agent-types/code_first_snippets_rust.json

@@ -1,5 +1,6 @@
 [
   {
+    "config": [],
     "constructor": {
       "description": "",
       "inputSchema": {
@@ -6202,6 +6203,7 @@
     "typeName": "BarAgent"
   },
   {
+    "config": [],
     "constructor": {
       "description": "",
       "inputSchema": {
@@ -12452,6 +12454,7 @@
     "typeName": "FooAgent"
   },
   {
+    "config": [],
     "constructor": {
       "description": "",
       "inputSchema": {

cli/golem-cli/test-data/goldenfiles/extracted-agent-types/code_first_snippets_ts.json

@@ -1,5 +1,6 @@
 [
   {
+    "config": [],
     "constructor": {
       "description": "TS Code First BarAgent",
       "inputSchema": {
@@ -5013,6 +5014,7 @@
     "typeName": "BarAgent"
   },
   {
+    "config": [],
     "constructor": {
       "description": "TS Code First FooAgent",
       "inputSchema": {

golem-api-grpc/proto/golem/component/agent.proto

@@ -49,6 +49,7 @@ message AgentType {
   AgentMode mode = 6;
   optional HttpMountDetails http_mount = 7;
   optional Snapshotting snapshotting = 8;
+  repeated ConfigKeyValueType config = 9;
 }
 
 message BinaryDescriptor {
@@ -350,3 +351,23 @@ message LoadSnapshotInvocation {
 message ProcessOplogEntriesInvocation {
   golem.worker.IdempotencyKey idempotency_key = 1;
 }
+
+message ConfigKeyValueType {
+  repeated string key = 1;
+  ConfigValueType value = 2;
+}
+
+message ConfigValueType {
+  oneof kind {
+    Local local = 1;
+    Shared shared = 2;
+  }
+
+  message Local {
+    wasm.rpc.Type value = 1;
+  }
+
+  message Shared {
+    wasm.rpc.Type value = 2;
+  }
+}

golem-api-grpc/proto/golem/component/component.proto

@@ -10,9 +10,16 @@ import "golem/component/component_files.proto";
 import "golem/component/component_metadata.proto";
 import "golem/component/plugin.proto";
 import "golem/component/component_id.proto";
+import "wasm/rpc/value_and_type.proto";
 import "golem/auth/environment_role.proto";
 import "google/protobuf/timestamp.proto";
 
+message LocalAgentConfigEntry {
+  string agent = 1;
+  repeated string key = 2;
+  wasm.rpc.ValueAndType value = 3;
+}
+
 message Component {
   ComponentId component_id = 1;
   uint64 revision = 2;
@@ -29,7 +36,10 @@ message Component {
   map<string, string> original_env = 13;
   map<string, string> config_vars = 14;
   map<string, string> original_config_vars = 15;
-  golem.common.Hash wasm_hash = 16;
-  golem.common.ApplicationId application_id = 17;
-  golem.common.Hash hash = 18;
+  repeated LocalAgentConfigEntry local_agent_config = 16;
+  golem.common.Hash wasm_hash = 17;
+  golem.common.ApplicationId application_id = 18;
+  golem.common.Hash hash = 19;
+  string transformed_object_store_key = 20;
+  string object_store_key = 21;
 }

golem-common/src/base_model/agent.rs

@@ -382,13 +382,15 @@ pub struct AgentType {
     pub mode: AgentMode,
     pub http_mount: Option<HttpMountDetails>,
     pub snapshotting: Snapshotting,
+    pub config: Vec<ConfigKeyValueType>,
 }
 
 impl AgentType {
     pub fn normalized(mut self) -> Self {
         self.methods.sort_by(|a, b| a.name.cmp(&b.name));
         self.dependencies
             .sort_by(|a, b| a.type_name.cmp(&b.type_name));
+        self.config.sort_by(|a, b| a.key.cmp(&b.key));
 
         Self {
             type_name: self.type_name,
@@ -403,6 +405,7 @@ impl AgentType {
             mode: self.mode,
             http_mount: self.http_mount,
             snapshotting: self.snapshotting,
+            config: self.config,
         }
     }
 
@@ -1112,6 +1115,58 @@ pub struct SnapshottingEveryNInvocation {
     pub count: u16,
 }
 
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[cfg_attr(
+    feature = "full",
+    derive(desert_rust::BinaryCodec, poem_openapi::Object, IntoValue, FromValue)
+)]
+#[cfg_attr(feature = "full", desert(evolution()))]
+#[cfg_attr(feature = "full", oai(rename_all = "camelCase"))]
+#[serde(rename_all = "camelCase")]
+pub struct ConfigKeyValueType {
+    pub key: Vec<String>,
+    pub value: ConfigValueType,
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[cfg_attr(
+    feature = "full",
+    derive(desert_rust::BinaryCodec, poem_openapi::Union, IntoValue, FromValue)
+)]
+#[cfg_attr(feature = "full", oai(discriminator_name = "type", one_of = true))]
+#[serde(tag = "type")]
+#[cfg_attr(feature = "full", desert(evolution()))]
+pub enum ConfigValueType {
+    Local(ConfigValueTypeLocal),
+    Shared(ConfigValueTypeShared),
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[cfg_attr(
+    feature = "full",
+    derive(desert_rust::BinaryCodec, poem_openapi::Object, IntoValue, FromValue)
+)]
+#[cfg_attr(feature = "full", oai(rename_all = "camelCase"))]
+#[serde(rename_all = "camelCase")]
+#[cfg_attr(feature = "full", desert(transparent))]
+#[cfg_attr(feature = "full", wit_transparent)]
+pub struct ConfigValueTypeLocal {
+    pub value: AnalysedType,
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[cfg_attr(
+    feature = "full",
+    derive(desert_rust::BinaryCodec, poem_openapi::Object, IntoValue, FromValue)
+)]
+#[cfg_attr(feature = "full", oai(rename_all = "camelCase"))]
+#[serde(rename_all = "camelCase")]
+#[cfg_attr(feature = "full", desert(transparent))]
+#[cfg_attr(feature = "full", wit_transparent)]
+pub struct ConfigValueTypeShared {
+    pub value: AnalysedType,
+}
+
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, IntoValue, FromValue)]
 #[cfg_attr(
     feature = "full",