wasi-http and error handling improvements#2949
Merged
Conversation
mschuwalow
approved these changes
Mar 9, 2026
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| pub struct HttpClientConfig { | ||
| /// Whether to use a shared HTTP connection pool for outgoing requests. | ||
| pub pool_enabled: bool, |
Contributor
There was a problem hiding this comment.
Can we make it an enum instead to be consistent with our other configs
Contributor
Author
|
The divergence issue with wasi-http that we experienced earlier was reproducible with the connection pool changes more easily. The fix is included. The problem was that request-body output stream operations were not persisted, so in case writing to the output failed (for example because a race cancelled the request, or any remote error happens) this error was not persisted and during replay caused a divergence: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasmtime side: golemcloud/wasmtime#5
Resolves #2068