Clippy

Author: vigoo

moonc_wasm/src/wasmoo_extern.rs

@@ -377,32 +377,29 @@ fn access(
     let path = Path::new(&path);
     let mode = args.get(1);
     let mode = mode.to_number(scope).unwrap().value() as i32;
-    if mode & F_OK != 0 {
-        if let Err(err) = metadata(path) {
+    if mode & F_OK != 0
+        && let Err(err) = metadata(path) {
             let message = v8::String::new(scope, &err.to_string()).unwrap();
             let exn = v8::Exception::error(scope, message);
             scope.throw_exception(exn);
             return;
         }
-    }
 
-    if mode & R_OK != 0 {
-        if let Err(err) = File::open(path) {
+    if mode & R_OK != 0
+        && let Err(err) = File::open(path) {
             let message = v8::String::new(scope, &err.to_string()).unwrap();
             let exn = v8::Exception::error(scope, message);
             scope.throw_exception(exn);
             return;
         }
-    }
 
-    if mode & W_OK != 0 {
-        if let Err(err) = OpenOptions::new().write(true).open(path) {
+    if mode & W_OK != 0
+        && let Err(err) = OpenOptions::new().write(true).open(path) {
             let message = v8::String::new(scope, &err.to_string()).unwrap();
             let exn = v8::Exception::error(scope, message);
             scope.throw_exception(exn);
             return;
         }
-    }
 
     if mode & X_OK != 0 {
         match metadata(path) {

src/lib.rs

@@ -811,8 +811,8 @@ impl MoonBitComponent {
             .ok_or_else(|| anyhow::anyhow!("Could not find world"))?;
         let mut imported_interfaces = Vec::new();
         for (_, item) in &world.imports {
-            if let wit_parser::WorldItem::Interface { id, .. } = item {
-                if let Some(interface) = self.resolve.as_ref().and_then(|r| r.interfaces.get(*id)) {
+            if let wit_parser::WorldItem::Interface { id, .. } = item
+                && let Some(interface) = self.resolve.as_ref().and_then(|r| r.interfaces.get(*id)) {
                     if let Some(interface_name) = interface.name.as_ref() {
                         let owner_package = interface.package.ok_or_else(|| {
                             anyhow::anyhow!(
@@ -839,7 +839,6 @@ impl MoonBitComponent {
                         ));
                     }
                 }
-            }
         }
         Ok(imported_interfaces)
     }
@@ -852,8 +851,8 @@ impl MoonBitComponent {
             .ok_or_else(|| anyhow::anyhow!("Could not find world"))?;
         let mut exported_interfaces = Vec::new();
         for (_, item) in &world.exports {
-            if let wit_parser::WorldItem::Interface { id, .. } = item {
-                if let Some(interface) = self.resolve.as_ref().and_then(|r| r.interfaces.get(*id)) {
+            if let wit_parser::WorldItem::Interface { id, .. } = item
+                && let Some(interface) = self.resolve.as_ref().and_then(|r| r.interfaces.get(*id)) {
                     if let Some(interface_name) = interface.name.as_ref() {
                         let owner_package = interface.package.ok_or_else(|| {
                             anyhow::anyhow!(
@@ -880,7 +879,6 @@ impl MoonBitComponent {
                         ));
                     }
                 }
-            }
         }
         Ok(exported_interfaces)
     }