refactor: optimize MSLV contract size

Author: skimaharvey

src/core/MultistrategyLockedVault.sol

@@ -134,15 +134,15 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
 
     /// @notice Initial rage quit cooldown period set at deployment
     /// @dev 7 days in seconds. Applied until governance changes it
-    uint256 public constant INITIAL_RAGE_QUIT_COOLDOWN_PERIOD = 7 days;
+    uint256 private constant INITIAL_RAGE_QUIT_COOLDOWN_PERIOD = 7 days;
 
     /// @notice Minimum allowed rage quit cooldown period
     /// @dev 1 day in seconds. Prevents cooldown from being set too short
-    uint256 public constant RANGE_MINIMUM_RAGE_QUIT_COOLDOWN_PERIOD = 1 days;
+    uint256 private constant RANGE_MINIMUM_RAGE_QUIT_COOLDOWN_PERIOD = 1 days;
 
     /// @notice Maximum allowed rage quit cooldown period
     /// @dev 30 days in seconds. Prevents cooldown from being set too long
-    uint256 public constant RANGE_MAXIMUM_RAGE_QUIT_COOLDOWN_PERIOD = 30 days;
+    uint256 private constant RANGE_MAXIMUM_RAGE_QUIT_COOLDOWN_PERIOD = 30 days;
 
     /// @notice Grace period delay for cooldown changes
     /// @dev 14 days in seconds. Users have this time to rage quit under old terms
@@ -534,19 +534,15 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
             revert SharesStillLocked();
         }
 
-        // Ensure user has sufficient balance
-        uint256 userBalance = balanceOf(owner);
-        if (userBalance < shares) {
-            revert InsufficientBalance();
-        }
-
         // Can only withdraw up to locked amount
         if (shares > custody.lockedShares) {
             revert ExceedsCustodiedAmount();
         }
 
         // Reduce locked shares by withdrawn amount
-        custody.lockedShares -= shares;
+        unchecked {
+            custody.lockedShares -= shares;
+        }
 
         // If all custodied shares withdrawn, reset custody info
         if (custody.lockedShares == 0) {
@@ -572,7 +568,11 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
 
         if (custody.lockedShares > 0) {
             uint256 senderBalance = balanceOf(sender_);
-            uint256 availableShares = senderBalance - custody.lockedShares;
+
+            uint256 availableShares;
+            unchecked {
+                availableShares = senderBalance - custody.lockedShares;
+            }
 
             // Revert if trying to transfer more than available shares
             if (amount_ > availableShares) {
@@ -625,7 +625,7 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
     function maxWithdraw(
         address owner_,
         uint256 maxLoss_
-    ) public view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
+    ) external view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
         return maxWithdraw(owner_, maxLoss_, new address[](0));
     }
 
@@ -670,11 +670,8 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
             balanceOf(owner_)
         );
 
-        // Get custody info to determine locked shares
-        uint256 lockedShares = custody.lockedShares;
-
         // Return minimum of parent max and custody limit
-        return Math.min(parentMax, lockedShares);
+        return Math.min(parentMax, custody.lockedShares);
     }
 
     /**
@@ -689,7 +686,7 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
     function maxRedeem(
         address owner_,
         uint256 maxLoss_
-    ) public view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
+    ) external view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
         return maxRedeem(owner_, maxLoss_, new address[](0));
     }
 
@@ -700,7 +697,7 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
      * @param owner_ Address that owns the shares
      * @return max Maximum redeemable shares (constrained by custody)
      */
-    function maxRedeem(address owner_) public view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
+    function maxRedeem(address owner_) external view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
         return maxRedeem(owner_, MAX_BPS, new address[](0));
     }
 }