refactor: make RAGE_QUIT_COOLDOWN_CHANGE_DELAY in MSLV

Author: skimaharvey

src/core/MultistrategyLockedVault.sol

@@ -146,7 +146,7 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
 
     /// @notice Grace period delay for cooldown changes
     /// @dev 14 days in seconds. Users have this time to rage quit under old terms
-    uint256 public constant RAGE_QUIT_COOLDOWN_CHANGE_DELAY = 14 days;
+    uint256 private constant RAGE_QUIT_COOLDOWN_CHANGE_DELAY = 14 days;
 
     /**
      * @dev Modifier to restrict access to regen governance only

test/proof-of-fixes/cantina-competition-september-2025/Finding231Fix.t.sol

@@ -19,6 +19,7 @@ contract Finding231Fix is Test {
     address internal governance = address(0x1);
     address internal feeRecipient = address(0x2);
     uint256 internal constant DEFAULT_PROFIT_MAX_UNLOCK = 7 days;
+    uint256 internal constant RAGE_QUIT_COOLDOWN_CHANGE_DELAY = 14 days;
     uint256 internal constant MAX_INT = type(uint256).max;
 
     function setUp() public {
@@ -51,7 +52,7 @@ contract Finding231Fix is Test {
         vault.proposeRageQuitCooldownPeriodChange(newPeriod);
 
         uint256 proposedAt = vault.rageQuitCooldownPeriodChangeTimestamp();
-        uint256 cancelTime = proposedAt + vault.RAGE_QUIT_COOLDOWN_CHANGE_DELAY() - 1;
+        uint256 cancelTime = proposedAt + RAGE_QUIT_COOLDOWN_CHANGE_DELAY - 1;
         vm.warp(cancelTime);
 
         vm.expectEmit(false, false, false, true);
@@ -72,7 +73,7 @@ contract Finding231Fix is Test {
         vault.proposeRageQuitCooldownPeriodChange(newPeriod);
 
         uint256 proposedAt = vault.rageQuitCooldownPeriodChangeTimestamp();
-        vm.warp(proposedAt + vault.RAGE_QUIT_COOLDOWN_CHANGE_DELAY());
+        vm.warp(proposedAt + RAGE_QUIT_COOLDOWN_CHANGE_DELAY);
 
         vm.expectRevert(IMultistrategyLockedVault.RageQuitCooldownPeriodChangeDelayElapsed.selector);
         vault.cancelRageQuitCooldownPeriodChange();

test/unit/core/multistrategyvault/LockedVaultTest.t.sol

@@ -23,6 +23,7 @@ contract LockedVaultTest is Test {
     address public fish = address(0x2);
     address public feeRecipient = address(0x3);
     address constant ZERO_ADDRESS = address(0);
+    uint256 internal constant RAGE_QUIT_COOLDOWN_CHANGE_DELAY = 14 days;
 
     uint256 public fishAmount = 10_000e18;
     uint256 public defaultProfitMaxUnlockTime = 7 days;
@@ -86,7 +87,7 @@ contract LockedVaultTest is Test {
         assertEq(vault.pendingRageQuitCooldownPeriod(), cooldownPeriod, "Pending period should be set");
 
         // Fast forward past delay period
-        vm.warp(block.timestamp + vault.RAGE_QUIT_COOLDOWN_CHANGE_DELAY() + 1);
+        vm.warp(block.timestamp + RAGE_QUIT_COOLDOWN_CHANGE_DELAY + 1);
 
         vault.finalizeRageQuitCooldownPeriodChange();
         assertEq(vault.rageQuitCooldownPeriod(), cooldownPeriod, "Rage quit cooldown period should be updated");
@@ -351,7 +352,7 @@ contract LockedVaultTest is Test {
         vm.stopPrank();
         vm.startPrank(gov);
         vault.proposeRageQuitCooldownPeriodChange(newCooldown);
-        vm.warp(block.timestamp + vault.RAGE_QUIT_COOLDOWN_CHANGE_DELAY() + 1);
+        vm.warp(block.timestamp + RAGE_QUIT_COOLDOWN_CHANGE_DELAY + 1);
         vault.finalizeRageQuitCooldownPeriodChange();
         vm.stopPrank();