refactor: added missing 2 parameters maxWithdraw/maxRedeem

Author: skimaharvey

src/core/MultistrategyLockedVault.sol

@@ -609,10 +609,33 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
         return Math.min(parentMax, custodyAssets);
     }
 
+    /**
+     * @notice Returns maximum assets that owner can withdraw with custom loss tolerance
+     * @dev Uses default queue for withdrawal strategies
+     * @param owner_ Address that owns the shares
+     * @param maxLoss_ Maximum acceptable loss in basis points (0-10000)
+     * @return max Maximum withdrawable assets (constrained by custody)
+     */
+
+    function maxWithdraw(
+        address owner_,
+        uint256 maxLoss_
+    ) public view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
+        return maxWithdraw(owner_, maxLoss_, new address[](0));
+    }
+
+    /**
+     * @notice Returns maximum assets that owner can withdraw with default parameters
+     * @dev Overload to match Vyper's default parameters behavior (maxLoss = 0, default queue)
+     *      Enforces custody constraints - returns 0 if cooldown period not passed
+     * @param owner_ Address that owns the shares
+     * @return max Maximum withdrawable assets (constrained by custody)
+     */
+
     function maxWithdraw(
         address owner_
     ) external view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
-        return maxWithdraw(owner_, MAX_BPS, new address[](0));
+        return maxWithdraw(owner_, 0, new address[](0));
     }
 
     /**
@@ -649,6 +672,22 @@ contract MultistrategyLockedVault is MultistrategyVault, IMultistrategyLockedVau
         return Math.min(parentMax, lockedShares);
     }
 
+    /**
+     * @notice Returns maximum shares that owner can redeem with default parameters
+     * @dev Overload to match Vyper's default parameters behavior (maxLoss = MAX_BPS, default queue)
+     *      Enforces custody constraints - returns 0 if cooldown period not passed
+     * @param owner_ Address that owns the shares
+     * @param maxLoss_ Maximum acceptable loss in basis points (0-10000)
+     * @return max Maximum redeemable shares (constrained by custody)
+     */
+
+    function maxRedeem(
+        address owner_,
+        uint256 maxLoss_
+    ) public view override(MultistrategyVault, IMultistrategyVault) returns (uint256) {
+        return maxRedeem(owner_, maxLoss_, new address[](0));
+    }
+
     /**
      * @notice Returns maximum shares that owner can redeem with default parameters
      * @dev Overload to match Vyper's default parameters behavior (maxLoss = MAX_BPS, default queue)

src/core/MultistrategyVault.sol

@@ -346,7 +346,7 @@ contract MultistrategyVault is IMultistrategyVault {
      * @param name_ New name for the vault token
      * @custom:security Only callable by roleManager
      */
-    function set_name(string memory name_) external override {
+    function setName(string memory name_) external override {
         require(msg.sender == roleManager, NotAllowed());
         name = name_;
     }
@@ -357,7 +357,7 @@ contract MultistrategyVault is IMultistrategyVault {
      * @param symbol_ New symbol ticker for the vault token
      * @custom:security Only callable by roleManager
      */
-    function set_symbol(string memory symbol_) external override {
+    function setSymbol(string memory symbol_) external override {
         require(msg.sender == roleManager, NotAllowed());
         symbol = symbol_;
     }
@@ -470,6 +470,18 @@ contract MultistrategyVault is IMultistrategyVault {
         emit UpdateDepositLimit(depositLimit_);
     }
 
+    /**
+     * @notice Sets a module contract to dynamically control deposit limits with default override behavior
+     * @dev Overload to match Vyper's default parameter behavior (shouldOverride = false by default)
+     *      See set_deposit_limit_module(address, bool) for full documentation
+     * @param depositLimitModule_ Address of IDepositLimitModule contract (or address(0) to disable)
+     * @custom:security Only callable by DEPOSIT_LIMIT_MANAGER role
+     * @custom:security Reverts if vault is shutdown
+     */
+    function set_deposit_limit_module(address depositLimitModule_) public {
+        set_deposit_limit_module(depositLimitModule_, false);
+    }
+
     /**
      * @notice Sets a module contract to dynamically control deposit limits
      * @dev Module overrides static depositLimit. Requires depositLimit = type(uint256).max
@@ -479,7 +491,7 @@ contract MultistrategyVault is IMultistrategyVault {
      * @custom:security Only callable by DEPOSIT_LIMIT_MANAGER role
      * @custom:security Reverts if vault is shutdown
      */
-    function set_deposit_limit_module(address depositLimitModule_, bool shouldOverride_) external override {
+    function set_deposit_limit_module(address depositLimitModule_, bool shouldOverride_) public override {
         require(_shutdown == false, VaultShutdown());
         _enforceRole(msg.sender, Roles.DEPOSIT_LIMIT_MANAGER);
 
@@ -1679,15 +1691,6 @@ contract MultistrategyVault is IMultistrategyVault {
         return _convertToAssets(shares_, Rounding.ROUND_DOWN);
     }
 
-    /**
-     * @notice Returns the default withdrawal queue
-     * @dev Same as getDefaultQueue()
-     * @return queue Array of strategy addresses in withdrawal priority order
-     */
-    function defaultQueue() external view override returns (address[] memory) {
-        return _defaultQueue;
-    }
-
     /**
      * @notice Returns maximum assets that can be deposited for a receiver
      * @dev Checks against depositLimit or depositLimitModule (if set)
@@ -1764,6 +1767,18 @@ contract MultistrategyVault is IMultistrategyVault {
             );
     }
 
+    /**
+     * @notice Returns maximum assets that owner can withdraw with custom loss tolerance
+     * @dev Uses default queue for withdrawal strategies
+     * @param owner_ Address that owns the shares
+     * @param maxLoss_ Maximum acceptable loss in basis points (0-10000)
+     * @return max Maximum withdrawable assets
+     */
+    function maxWithdraw(address owner_, uint256 maxLoss_) external view virtual returns (uint256) {
+        address[] memory emptyArray = new address[](0);
+        return _max_withdraw(owner_, maxLoss_, emptyArray);
+    }
+
     /**
      * @notice Returns maximum assets that owner can withdraw with default parameters
      * @dev Overload to match Vyper's default parameters behavior (maxLoss = 0, default queue)
@@ -1775,6 +1790,22 @@ contract MultistrategyVault is IMultistrategyVault {
         return _max_withdraw(owner_, 0, emptyArray);
     }
 
+    /**
+     * @notice Returns maximum shares that owner can redeem with custom loss tolerance
+     * @dev Uses default queue for withdrawal strategies
+     * @param owner_ Address that owns the shares
+     * @param maxLoss_ Maximum acceptable loss in basis points (0-10000)
+     * @return max Maximum redeemable shares
+     */
+    function maxRedeem(address owner_, uint256 maxLoss_) external view virtual returns (uint256) {
+        address[] memory emptyArray = new address[](0);
+        return
+            Math.min(
+                _convertToShares(_max_withdraw(owner_, maxLoss_, emptyArray), Rounding.ROUND_DOWN),
+                _balanceOf[owner_]
+            );
+    }
+
     /**
      * @notice Returns maximum shares that owner can redeem with default parameters
      * @dev Overload to match Vyper's default parameters behavior (maxLoss = MAX_BPS, default queue)
@@ -1833,31 +1864,6 @@ contract MultistrategyVault is IMultistrategyVault {
         return API_VERSION;
     }
 
-    // ============================================
-    // VIEW FUNCTIONS - STRATEGY QUERIES
-    // ============================================
-
-    /**
-     * @notice Calculates the unrealized losses for a withdrawal from strategy
-     * @dev Compares strategy's actual asset value vs recorded debt
-     *      If strategy is underwater, user takes proportional share of loss
-     *
-     *      Formula: loss = assetsNeeded - (assetsNeeded * strategyAssets / currentDebt)
-     *
-     * @param strategy_ Address of the strategy
-     * @param assetsNeeded_ Amount of assets to withdraw from strategy
-     * @return loss User's share of unrealized losses
-     */
-    function assess_share_of_unrealised_losses(
-        address strategy_,
-        uint256 assetsNeeded_
-    ) external view returns (uint256) {
-        uint256 currentDebt = _strategies[strategy_].currentDebt;
-        require(currentDebt >= assetsNeeded_, NotEnoughDebt());
-
-        return _assess_share_of_unrealised_losses(strategy_, currentDebt, assetsNeeded_);
-    }
-
     // ============================================
     // VIEW FUNCTIONS - PROFIT LOCKING
     // ============================================

src/core/interfaces/IMultistrategyVault.sol

@@ -360,7 +360,6 @@ interface IMultistrategyVault {
     // NOTE: The following functions are declared for interface completeness where
     // some implementations may expose equivalent public state variables.
     function strategies(address strategy) external view returns (StrategyParams memory);
-    function defaultQueue() external view returns (address[] memory);
     function useDefaultQueue() external view returns (bool);
     function autoAllocate() external view returns (bool);
     function minimumTotalIdle() external view returns (uint256);
@@ -397,10 +396,12 @@ interface IMultistrategyVault {
 
     // MaxWithdraw functions with different parameter combinations to match Vyper
     function maxWithdraw(address owner) external view returns (uint256);
+    function maxWithdraw(address owner, uint256 maxLoss) external view returns (uint256);
     function maxWithdraw(address owner, uint256 maxLoss, address[] memory strategies) external view returns (uint256);
 
     // MaxRedeem functions with different parameter combinations to match Vyper
     function maxRedeem(address owner) external view returns (uint256);
+    function maxRedeem(address owner, uint256 maxLoss) external view returns (uint256);
     function maxRedeem(address owner, uint256 maxLoss, address[] memory strategies) external view returns (uint256);
 
     function FACTORY() external view returns (address);
@@ -467,8 +468,8 @@ interface IMultistrategyVault {
     ) external returns (bool);
 
     // Management Functions
-    function set_name(string memory name) external;
-    function set_symbol(string memory symbol) external;
+    function setName(string memory name) external;
+    function setSymbol(string memory symbol) external;
     function set_accountant(address newAccountant) external;
     function set_default_queue(address[] memory newDefaultQueue) external;
     function set_use_default_queue(bool useDefaultQueue) external;