refactor[core]: improve code formatting for health check imports and assertions in tests

Author: aschlean

src/golf/core/builder.py

@@ -572,10 +572,12 @@ def _generate_server(self) -> None:
 
         # Add health check imports if enabled
         if self.settings.health_check_enabled:
-            imports.extend([
-                "from starlette.requests import Request",
-                "from starlette.responses import PlainTextResponse"
-            ])
+            imports.extend(
+                [
+                    "from starlette.requests import Request",
+                    "from starlette.responses import PlainTextResponse",
+                ]
+            )
 
         # Get transport-specific configuration
         transport_config = self._get_transport_config(self.settings.transport)
@@ -904,7 +906,9 @@ def _generate_server(self) -> None:
         if self.settings.health_check_enabled:
             health_check_code = [
                 "# Add health check route",
-                "@mcp.custom_route('" + self.settings.health_check_path + "', methods=[\"GET\"])",
+                "@mcp.custom_route('"
+                + self.settings.health_check_path
+                + '\', methods=["GET"])',
                 "async def health_check(request: Request) -> PlainTextResponse:",
                 '    """Health check endpoint for Kubernetes and load balancers."""',
                 f'    return PlainTextResponse("{self.settings.health_check_response}")',

src/golf/core/config.py

@@ -106,12 +106,8 @@ class Settings(BaseSettings):
     health_check_enabled: bool = Field(
         False, description="Enable health check endpoint"
     )
-    health_check_path: str = Field(
-        "/health", description="Health check endpoint path"
-    )
-    health_check_response: str = Field(
-        "OK", description="Health check response text"
-    )
+    health_check_path: str = Field("/health", description="Health check endpoint path")
+    health_check_response: str = Field("OK", description="Health check response text")
 
 
 def find_config_path(start_path: Path | None = None) -> Path | None:

tests/commands/test_init.py

@@ -91,17 +91,19 @@ def test_api_key_template_compatibility_with_health_check(
         # Check that we can add health check configuration
         config_file = project_dir / "golf.json"
         config = json.loads(config_file.read_text())
-        
+
         # Add health check configuration
-        config.update({
-            "health_check_enabled": True,
-            "health_check_path": "/status",
-            "health_check_response": "API Ready"
-        })
-        
+        config.update(
+            {
+                "health_check_enabled": True,
+                "health_check_path": "/status",
+                "health_check_response": "API Ready",
+            }
+        )
+
         # Should be able to write back without issues
         config_file.write_text(json.dumps(config, indent=2))
-        
+
         # Verify it can be read back
         updated_config = json.loads(config_file.read_text())
         assert updated_config["health_check_enabled"] is True

tests/core/test_builder.py

@@ -280,7 +280,7 @@ def test_generates_health_check_when_enabled(
             "name": "HealthProject",
             "health_check_enabled": True,
             "health_check_path": "/health",
-            "health_check_response": "OK"
+            "health_check_response": "OK",
         }
         config_file.write_text(json.dumps(config))
 
@@ -321,7 +321,7 @@ def simple_tool() -> Output:
         assert "from starlette.responses import PlainTextResponse" in server_code
 
         # Should contain health check route definition
-        assert "@mcp.custom_route(\"/health\", methods=[\"GET\"])" in server_code
+        assert '@mcp.custom_route("/health", methods=["GET"])' in server_code
         assert (
             "async def health_check(request: Request) -> PlainTextResponse:"
             in server_code
@@ -338,7 +338,7 @@ def test_health_check_with_custom_config(
             "name": "CustomHealthProject",
             "health_check_enabled": True,
             "health_check_path": "/status",
-            "health_check_response": "Service is running"
+            "health_check_response": "Service is running",
         }
         config_file.write_text(json.dumps(config))
 
@@ -371,7 +371,7 @@ def simple_tool() -> Output:
         server_code = server_file.read_text()
 
         # Should use custom path and response
-        assert "@mcp.custom_route(\"/status\", methods=[\"GET\"])" in server_code
+        assert '@mcp.custom_route("/status", methods=["GET"])' in server_code
         assert 'return PlainTextResponse("Service is running")' in server_code
 
     def test_no_health_check_when_disabled(
@@ -380,10 +380,7 @@ def test_no_health_check_when_disabled(
         """Test that health check route is not generated when disabled."""
         # Ensure health check is disabled (default)
         config_file = sample_project / "golf.json"
-        config = {
-            "name": "NoHealthProject",
-            "health_check_enabled": False
-        }
+        config = {"name": "NoHealthProject", "health_check_enabled": False}
         config_file.write_text(json.dumps(config))
 
         # Create a simple tool
@@ -426,18 +423,15 @@ def test_health_check_without_starlette_imports_when_disabled(
         # Create a minimal project without any auth or other features
         project_dir = temp_dir / "minimal_project"
         project_dir.mkdir()
-        
+
         # Create minimal golf.json with only health check disabled
         config_file = project_dir / "golf.json"
-        config = {
-            "name": "MinimalProject",
-            "health_check_enabled": False
-        }
+        config = {"name": "MinimalProject", "health_check_enabled": False}
         config_file.write_text(json.dumps(config))
-        
+
         # Create minimal tool structure
         (project_dir / "tools").mkdir()
-        (project_dir / "resources").mkdir() 
+        (project_dir / "resources").mkdir()
         (project_dir / "prompts").mkdir()
 
         # Create a simple tool
@@ -470,8 +464,7 @@ def simple_tool() -> Output:
 
         # Most importantly, no health check route should be generated
         assert (
-            "@mcp.custom_route" not in server_code
-            or "health_check" not in server_code
+            "@mcp.custom_route" not in server_code or "health_check" not in server_code
         )
         assert "async def health_check" not in server_code
 
@@ -480,10 +473,7 @@ def test_health_check_docstring_generation(
     ) -> None:
         """Test that health check function has proper docstring."""
         config_file = sample_project / "golf.json"
-        config = {
-            "name": "DocstringProject",
-            "health_check_enabled": True
-        }
+        config = {"name": "DocstringProject", "health_check_enabled": True}
         config_file.write_text(json.dumps(config))
 
         # Create a simple tool
@@ -515,20 +505,25 @@ def simple_tool() -> Output:
         server_code = server_file.read_text()
 
         # Should include descriptive docstring
-        assert '"""Health check endpoint for Kubernetes and load balancers."""' in server_code
+        assert (
+            '"""Health check endpoint for Kubernetes and load balancers."""'
+            in server_code
+        )
 
 
 class TestHealthCheckEdgeCases:
     """Test edge cases and error conditions for health check generation."""
 
-    def test_health_check_with_empty_response(self, sample_project: Path, temp_dir: Path) -> None:
+    def test_health_check_with_empty_response(
+        self, sample_project: Path, temp_dir: Path
+    ) -> None:
         """Test health check with empty response string."""
         config_file = sample_project / "golf.json"
         config = {
             "name": "EmptyResponseProject",
             "health_check_enabled": True,
             "health_check_path": "/health",
-            "health_check_response": ""
+            "health_check_response": "",
         }
         config_file.write_text(json.dumps(config))
 
@@ -563,14 +558,16 @@ def simple_tool() -> Output:
         # Should handle empty string gracefully
         assert 'return PlainTextResponse("")' in server_code
 
-    def test_health_check_path_sanitization(self, sample_project: Path, temp_dir: Path) -> None:
+    def test_health_check_path_sanitization(
+        self, sample_project: Path, temp_dir: Path
+    ) -> None:
         """Test that health check paths are properly handled in generated code."""
         config_file = sample_project / "golf.json"
         config = {
             "name": "PathSanitizationProject",
             "health_check_enabled": True,
             "health_check_path": "/api/v1/health-check",
-            "health_check_response": "All systems operational"
+            "health_check_response": "All systems operational",
         }
         config_file.write_text(json.dumps(config))
 
@@ -603,23 +600,22 @@ def simple_tool() -> Output:
         server_code = server_file.read_text()
 
         # Should properly handle complex paths
-        assert "@mcp.custom_route(\"/api/v1/health-check\", methods=[\"GET\"])" in server_code
+        assert (
+            '@mcp.custom_route("/api/v1/health-check", methods=["GET"])' in server_code
+        )
         assert 'return PlainTextResponse("All systems operational")' in server_code
 
     def test_health_check_imports_only_when_needed(self, temp_dir: Path) -> None:
         """Test that health check route is only generated when explicitly enabled."""
         # Create a minimal project without any auth or other features
         project_dir = temp_dir / "minimal_project"
         project_dir.mkdir()
-        
+
         # Create minimal golf.json with health check disabled
         config_file = project_dir / "golf.json"
-        config = {
-            "name": "MinimalProject", 
-            "health_check_enabled": False
-        }
+        config = {"name": "MinimalProject", "health_check_enabled": False}
         config_file.write_text(json.dumps(config))
-        
+
         # Create minimal tool structure
         (project_dir / "tools").mkdir()
         (project_dir / "resources").mkdir()
@@ -655,7 +651,7 @@ def simple_tool() -> Output:
 
         # Should not have health check route when disabled
         assert "async def health_check" not in server_code
-        
+
         # Now test with health check enabled
         config["health_check_enabled"] = True
         config["health_check_path"] = "/health"
@@ -664,6 +660,7 @@ def simple_tool() -> Output:
 
         # Clean and regenerate
         import shutil
+
         shutil.rmtree(output_dir)
 
         settings = load_settings(project_dir)

tests/core/test_config.py

@@ -111,7 +111,7 @@ def test_health_check_configuration_from_json(self, temp_dir: Path) -> None:
             "name": "HealthProject",
             "health_check_enabled": True,
             "health_check_path": "/status",
-            "health_check_response": "Service is healthy"
+            "health_check_response": "Service is healthy",
         }
 
         config_file = temp_dir / "golf.json"
@@ -124,10 +124,7 @@ def test_health_check_configuration_from_json(self, temp_dir: Path) -> None:
 
     def test_health_check_partial_configuration(self, temp_dir: Path) -> None:
         """Test that partial health check configuration uses defaults for missing values."""
-        config = {
-            "name": "PartialHealthProject",
-            "health_check_enabled": True
-        }
+        config = {"name": "PartialHealthProject", "health_check_enabled": True}
 
         config_file = temp_dir / "golf.json"
         config_file.write_text(json.dumps(config))