Merge pull request #98 from golf-mcp/asch/remove-platform

Asch/remove platform

Author: aschlean

.gitignore

@@ -11,4 +11,8 @@ dist/
 Makefile
 htmlcov/
 .ruff_cache/
-new/
+new/
+
+# Generated endpoints file (created by editable install)
+src/golf/_endpoints.py
+build.sh

setup.py

@@ -0,0 +1,87 @@
+"""Custom setup.py for golf-mcp with URL injection."""
+
+from setuptools import setup
+from setuptools.command.build_py import build_py as _build_py
+from setuptools.command.develop import develop as _develop
+import os
+import pathlib
+import sys
+
+TEMPLATE_REL = "src/golf/_endpoints.py.in"
+PACKAGE_OUT_REL = "golf/_endpoints.py"
+
+
+def render_endpoints(require_env_vars: bool = True):
+    """Render the endpoints template with environment variables."""
+    tpl_path = pathlib.Path(TEMPLATE_REL)
+    if not tpl_path.exists():
+        raise FileNotFoundError(f"Template not found: {tpl_path}")
+
+    # Get environment variables
+    platform_url = os.environ.get("GOLF_PLATFORM_API_URL")
+    otel_url = os.environ.get("GOLF_OTEL_ENDPOINT") 
+    
+    # For production builds, require environment variables
+    # For development/editable installs, use fallback values
+    if require_env_vars and (not platform_url or not otel_url):
+        raise SystemExit(
+            "Missing required environment variables for URL injection:\n"
+            "  GOLF_PLATFORM_API_URL\n" 
+            "  GOLF_OTEL_ENDPOINT\n"
+            "Set these before building the package."
+        )
+    
+    # Use environment variables if available, otherwise fallback to development URLs
+    values = {
+        "PLATFORM_API_URL": platform_url or "http://localhost:8000/api/resources",
+        "OTEL_ENDPOINT": otel_url or "http://localhost:4318/v1/traces",
+    }
+    
+    try:
+        rendered = tpl_path.read_text(encoding="utf-8").format(**values)
+    except KeyError as e:
+        raise SystemExit(f"Missing template key: {e}") from e
+    
+    return rendered
+
+
+class build_py(_build_py):
+    """Custom build_py that renders endpoints into the build_lib (wheel contents)."""
+    
+    def run(self):
+        # First run the normal build
+        super().run()
+        
+        # Then render endpoints into the build_lib
+        # Skip env var requirement if in CI environment or if this looks like a test install
+        is_ci = os.environ.get("CI") or os.environ.get("GITHUB_ACTIONS")
+        rendered = render_endpoints(require_env_vars=not is_ci)
+        out_file = pathlib.Path(self.build_lib) / PACKAGE_OUT_REL
+        out_file.parent.mkdir(parents=True, exist_ok=True)
+        out_file.write_text(rendered, encoding="utf-8")
+        print(f"Generated {PACKAGE_OUT_REL} with injected URLs", file=sys.stderr)
+
+
+class develop(_develop):
+    """Custom develop for editable installs - generates endpoints file in source tree."""
+    
+    def run(self):
+        # Run normal develop command first
+        super().run()
+        
+        # Generate a working copy file for editable installs (use fallback URLs if env vars missing)
+        rendered = render_endpoints(require_env_vars=False)
+        # For editable installs, write into the source tree so imports work
+        src_file = pathlib.Path("src") / PACKAGE_OUT_REL
+        src_file.parent.mkdir(parents=True, exist_ok=True)
+        src_file.write_text(rendered, encoding="utf-8")
+        print(f"Generated dev-time {PACKAGE_OUT_REL} in source tree", file=sys.stderr)
+        print(f"Note: {src_file} is gitignored and should not be committed", file=sys.stderr)
+
+
+setup(
+    cmdclass={
+        "build_py": build_py,
+        "develop": develop,
+    }
+)

src/golf/__init__.py

@@ -1 +1,9 @@
 __version__ = "0.2.0"
+
+# Import endpoints with fallback for dev mode
+try:
+    # In built wheels, this exists (generated from _endpoints.py.in)
+    from . import _endpoints
+except ImportError:
+    # In editable/dev installs, fall back to env-based values
+    from . import _endpoints_fallback as _endpoints

src/golf/_endpoints.py.in

@@ -0,0 +1,6 @@
+# Auto-generated at build time by setup.py:build_py
+# This template contains placeholders that are replaced during build
+
+# Platform endpoints
+PLATFORM_API_URL = "{PLATFORM_API_URL}"
+OTEL_ENDPOINT = "{OTEL_ENDPOINT}"

src/golf/_endpoints_fallback.py

@@ -0,0 +1,10 @@
+"""Fallback endpoints for development/editable installs."""
+
+import os
+
+# These are used when the generated _endpoints.py doesn't exist (dev mode)
+# or when environment variables override the built-in values
+
+PLATFORM_API_URL = os.getenv("GOLF_PLATFORM_API_URL", "http://localhost:8000/api/resources")
+
+OTEL_ENDPOINT = os.getenv("GOLF_OTEL_ENDPOINT", "http://localhost:4318/v1/traces")

src/golf/core/platform.py

@@ -12,6 +12,14 @@
 from golf.core.config import Settings
 from golf.core.parser import ComponentType, ParsedComponent
 
+# Import endpoints with fallback for dev mode
+try:
+    # In built wheels, this exists (generated from _endpoints.py.in)
+    from golf import _endpoints  # type: ignore
+except ImportError:
+    # In editable/dev installs, fall back to env-based values
+    from golf import _endpoints_fallback as _endpoints  # type: ignore
+
 console = Console()
 
 
@@ -65,7 +73,7 @@ async def register_project_with_platform(
     try:
         async with httpx.AsyncClient(timeout=10.0) as client:
             response = await client.post(
-                "https://golf-backend.golf-auth-1.authed-qukc4.ryvn.run/api/resources",
+                _endpoints.PLATFORM_API_URL,
                 json=metadata,
                 headers={
                     "X-Golf-Key": api_key,

src/golf/telemetry/instrumentation.py

@@ -13,6 +13,14 @@
 from collections import OrderedDict
 
 from opentelemetry import baggage, trace
+
+# Import endpoints with fallback for dev mode
+try:
+    # In built wheels, this exists (generated from _endpoints.py.in)
+    from golf import _endpoints  # type: ignore
+except ImportError:
+    # In editable/dev installs, fall back to env-based values
+    from golf import _endpoints_fallback as _endpoints  # type: ignore
 from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.sdk.trace import TracerProvider
@@ -70,9 +78,7 @@ def init_telemetry(service_name: str = "golf-mcp-server") -> TracerProvider | No
 
         # Only set endpoint if not already configured (allow user override)
         if not os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT"):
-            os.environ["OTEL_EXPORTER_OTLP_ENDPOINT"] = (
-                "https://golf-backend.golf-auth-1.authed-qukc4.ryvn.run/api/v1/otel"
-            )
+            os.environ["OTEL_EXPORTER_OTLP_ENDPOINT"] = _endpoints.OTEL_ENDPOINT
 
         # Set Golf platform headers (append to existing if present)
         existing_headers = os.environ.get("OTEL_EXPORTER_OTLP_HEADERS", "")

tests/core/test_instrumentation.py

@@ -55,10 +55,9 @@ def test_init_telemetry_with_golf_platform_auto_config(self, monkeypatch):
             provider = init_telemetry("test-service")
             assert provider is not None
             assert os.environ.get("OTEL_TRACES_EXPORTER") == "otlp_http"
-            assert (
-                os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT")
-                == "https://golf-backend.golf-auth-1.authed-qukc4.ryvn.run/api/v1/otel"
-            )
+            from golf import _endpoints
+
+            assert os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT") == _endpoints.OTEL_ENDPOINT
 
     def test_init_telemetry_with_headers(self, monkeypatch):
         """Test telemetry initialization with custom headers."""
@@ -337,10 +336,9 @@ def test_golf_platform_integration_workflow(self, monkeypatch):
 
         # Verify auto-configuration
         assert os.environ.get("OTEL_TRACES_EXPORTER") == "otlp_http"
-        assert (
-            os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT")
-            == "https://golf-backend.golf-auth-1.authed-qukc4.ryvn.run/api/v1/otel"
-        )
+        from golf import _endpoints
+
+        assert os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT") == _endpoints.OTEL_ENDPOINT
         assert "X-Golf-Key=golf_test_key_123" in os.environ.get("OTEL_EXPORTER_OTLP_HEADERS", "")
 
     def test_mixed_component_instrumentation(self):

tests/core/test_platform.py

@@ -67,7 +67,9 @@ def test_function() -> Output:
             # Verify the HTTP request was made correctly
             mock_context.post.assert_called_once()
             call_args = mock_context.post.call_args
-            assert call_args.args[0] == "https://golf-backend.golf-auth-1.authed-qukc4.ryvn.run/api/resources"
+            from golf import _endpoints
+
+            assert call_args.args[0] == _endpoints.PLATFORM_API_URL
 
             # Verify request headers
             headers = call_args.kwargs["headers"]