Skip to content

Commit 7fa8b35

Browse files
author
vals
committed
Optimized
1 parent eaf746e commit 7fa8b35

File tree

2 files changed

+6
-19
lines changed

2 files changed

+6
-19
lines changed

layout/layout.go

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,9 @@ func (l *Layout) Set(flags ...Layout) (Layout, error) {
139139

140140
for _, flag := range flags {
141141
if !flag.IsValid() {
142-
return *l, fmt.Errorf("the %d is invalid flag value", flag)
143-
}
144-
145-
if ok, _ := r.Contains(flag); !ok {
146-
r += Layout(flag)
142+
return *l, fmt.Errorf("the %d is an invalid flag value", flag)
147143
}
144+
r |= flag
148145
}
149146

150147
*l = r
@@ -156,15 +153,11 @@ func (l *Layout) Set(flags ...Layout) (Layout, error) {
156153
// an error if one or more invalid flags are specified.
157154
func (l *Layout) Add(flags ...Layout) (Layout, error) {
158155
r := *l
159-
160156
for _, flag := range flags {
161157
if !flag.IsValid() {
162-
return *l, fmt.Errorf("the %d is invalid flag value", flag)
163-
}
164-
165-
if ok, _ := r.Contains(flag); !ok {
166-
r += Layout(flag)
158+
return *l, fmt.Errorf("the %d is an invalid flag value", flag)
167159
}
160+
r |= flag
168161
}
169162

170163
*l = r
@@ -176,15 +169,11 @@ func (l *Layout) Add(flags ...Layout) (Layout, error) {
176169
// old value and an error if one or more invalid flags are specified.
177170
func (l *Layout) Delete(flags ...Layout) (Layout, error) {
178171
r := *l
179-
180172
for _, flag := range flags {
181173
if !flag.IsValid() {
182-
return *l, fmt.Errorf("the %d is invalid flag value", flag)
183-
}
184-
185-
if ok, _ := r.Contains(flag); ok {
186-
r -= Layout(flag)
174+
return *l, fmt.Errorf("the %d is an invalid flag value", flag)
187175
}
176+
r &^= flag
188177
}
189178

190179
*l = r

level/level.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ func (l *Level) Set(flags ...Level) (Level, error) {
164164
// an error if one or more invalid flags are specified.
165165
func (l *Level) Add(flags ...Level) (Level, error) {
166166
r := *l
167-
168167
for _, flag := range flags {
169168
if !flag.IsValid() {
170169
return *l, fmt.Errorf("the %d is an invalid flag value", flag)
@@ -181,7 +180,6 @@ func (l *Level) Add(flags ...Level) (Level, error) {
181180
// old value and an error if one or more invalid flags are specified.
182181
func (l *Level) Delete(flags ...Level) (Level, error) {
183182
r := *l
184-
185183
for _, flag := range flags {
186184
if !flag.IsValid() {
187185
return *l, fmt.Errorf("the %d is an invalid flag value", flag)

0 commit comments

Comments
 (0)