Merge pull request #22 from gomicro/empty-token

that way wasn't working, actually show an error if the token is empty

Author: dan9186

client/context.go

@@ -8,15 +8,13 @@ const (
 	clientConextKey ctxKey = "client"
 )
 
-func WithClient(ctx context.Context, tkn string) context.Context {
-	ctx, cancel := context.WithCancelCause(ctx)
-
+func WithClient(ctx context.Context, tkn string) (context.Context, error) {
 	c, err := New(ctx, tkn)
 	if err != nil {
-		cancel(err)
+		return nil, err
 	}
 
-	return context.WithValue(ctx, clientConextKey, c)
+	return context.WithValue(ctx, clientConextKey, c), nil
 }
 
 func ClientFromContext(ctx context.Context) (*Client, error) {

cmd/root.go

@@ -42,9 +42,14 @@ func Execute() {
 		c.Github.Token = tkn
 	}
 
-	ctx := client.WithClient(context.Background(), c.Github.Token)
+	ctx, err := client.WithClient(context.Background(), c.Github.Token)
+	if err != nil {
+		fmt.Printf("Error: %s\n", err.Error())
+		os.Exit(1)
+	}
 
-	if err := rootCmd.ExecuteContext(ctx); err != nil {
+	err = rootCmd.ExecuteContext(ctx)
+	if err != nil {
 		fmt.Printf("Error: %s\n", err.Error())
 		os.Exit(1)
 	}