review

Signed-off-by: Robert Zaremba <robert@zaremba.ch>

Author: robert-zaremba

packages/btcindexer/db/migrations/0001_initial_schema.sql

@@ -16,7 +16,7 @@ CREATE INDEX IF NOT EXISTS btc_blocks_is_scanned_height ON btc_blocks (is_scanne
 -- This table tracks the nBTC deposit txs (minting)
 CREATE TABLE IF NOT EXISTS nbtc_minting (
 	tx_id TEXT NOT NULL PRIMARY KEY,
-	address_id TEXT NOT NULL,  -- nbtc pkg is linked through address_id
+	address_id TEXT NOT NULL,  -- nbtc pkg is linked through address_id -> nbtc_deposit_addresses.setup_id
 	sender TEXT NOT NULL,
 	vout INTEGER NOT NULL,
 	block_hash TEXT,

packages/btcindexer/scripts/seed-config.ts

@@ -67,9 +67,8 @@ async function main() {
 			continue;
 		}
 
-		const checkAddrQuery = `SELECT id FROM nbtc_deposit_addresses WHERE setup_id = ${setupId} AND deposit_address = '${entry.btc_address}'`;
+		const checkAddrQuery = `SELECT 1 FROM nbtc_deposit_addresses WHERE setup_id = ${setupId} AND deposit_address = '${entry.btc_address}'`;
 		const existingAddrId = await executeQuery<number>(checkAddrQuery, DB_NAME, local, "id");
-
 		if (existingAddrId) {
 			continue;
 		}