PR comments

Signed-off-by: Ravindra Meena <rmeena840@gmail.com>

Author: rmeena840

packages/btcindexer/src/sanction.test.ts

@@ -1,9 +1,27 @@
-import { describe, it, expect, beforeAll, afterAll, beforeEach } from "bun:test";
+import { describe, it, expect, beforeAll, afterAll, beforeEach, mock } from "bun:test";
 import { Miniflare } from "miniflare";
 import type { D1Database } from "@cloudflare/workers-types";
 import { initDb } from "@gonative-cc/lib/test-helpers/init_db";
 import { processSanctionedAddress } from "./sanction";
 
+const MOCK_NDJSON = [
+	JSON.stringify({
+		properties: {
+			cryptoWallets: [{ properties: { currency: ["XBT"], publicKey: ["1BTC_TEST_ADDR"] } }],
+		},
+	}),
+	JSON.stringify({
+		properties: {
+			cryptoWallets: [{ properties: { currency: ["SUI"], publicKey: ["0xSUI_TEST_ADDR"] } }],
+		},
+	}),
+	JSON.stringify({
+		properties: {
+			cryptoWallets: [{ properties: { currency: ["ETH"], publicKey: ["0xETH_IGNORED"] } }],
+		},
+	}),
+].join("\n");
+
 let mf: Miniflare;
 let db: D1Database;
 let env: Env;
@@ -24,51 +42,91 @@ afterAll(async () => {
 beforeEach(async () => {
 	db = await mf.getD1Database("DB");
 	await initDb(db);
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any
-	env = (await mf.getBindings()) as any;
+	env = await mf.getBindings();
+
+	global.fetch = mock(async () => {
+		return {
+			ok: true,
+			status: 200,
+			body: {
+				getReader: () => {
+					let sent = false;
+					return {
+						read: async () => {
+							if (!sent) {
+								sent = true;
+								return { done: false, value: Buffer.from(MOCK_NDJSON) };
+							}
+							return { done: true, value: undefined };
+						},
+					};
+				},
+			},
+		} as unknown as Response;
+	}) as unknown as typeof fetch;
 });
 
 describe("processSanctionedAddress", () => {
-	it("should fetch and store sanctioned addresses", async () => {
+	it("should fetch, parse, and store sanctioned addresses from stream", async () => {
 		await processSanctionedAddress(env);
 
 		const { results } = await db.prepare("SELECT * FROM sanctioned_addresses").all();
-		expect(results.length).toBeGreaterThan(0);
+		expect(results.length).toBe(2);
 	});
 
-	it("should store BTC and SUI addresses separately", async () => {
+	it("should map currencies correctly (XBT->BTC, SUI->SUI)", async () => {
 		await processSanctionedAddress(env);
 
-		const btcAddresses = await db
+		const btcRecord = await db
 			.prepare("SELECT * FROM sanctioned_addresses WHERE address_type = 'BTC'")
-			.all();
-		const suiAddresses = await db
-			.prepare("SELECT * FROM sanctioned_addresses WHERE address_type = 'SUI'")
-			.all();
+			.first();
+		expect(btcRecord).not.toBeNull();
+		expect(btcRecord?.wallet_address).toBe("1BTC_TEST_ADDR");
 
-		expect(btcAddresses.results.length).toBeGreaterThanOrEqual(0);
-		expect(suiAddresses.results.length).toBeGreaterThanOrEqual(0);
+		const suiRecord = await db
+			.prepare("SELECT * FROM sanctioned_addresses WHERE address_type = 'SUI'")
+			.first();
+		expect(suiRecord).not.toBeNull();
+		expect(suiRecord?.wallet_address).toBe("0xSUI_TEST_ADDR");
 	});
 
-	it("should replace existing addresses on subsequent runs", async () => {
+	it("should strictly replace existing database records", async () => {
 		await db
 			.prepare(
 				"INSERT INTO sanctioned_addresses (wallet_address, address_type) VALUES (?, ?)",
 			)
-			.bind("test_address", "BTC")
+			.bind("old_stale_address", "BTC")
 			.run();
 
-		const before = await db.prepare("SELECT * FROM sanctioned_addresses").all();
-		expect(before.results.length).toEqual(1);
-
 		await processSanctionedAddress(env);
 
-		const after = await db.prepare("SELECT * FROM sanctioned_addresses").all();
-		expect(after.results.length).toBeGreaterThan(0);
-
-		const testAddr = await db
-			.prepare("SELECT * FROM sanctioned_addresses WHERE wallet_address = 'test_address'")
+		const staleCheck = await db
+			.prepare(
+				"SELECT * FROM sanctioned_addresses WHERE wallet_address = 'old_stale_address'",
+			)
 			.first();
-		expect(testAddr).toBeNull();
+		expect(staleCheck).toBeNull();
+
+		const newCheck = await db.prepare("SELECT * FROM sanctioned_addresses").all();
+		expect(newCheck.results.length).toBe(2);
+	});
+
+	it("should handle empty or malformed API responses gracefully", async () => {
+		global.fetch = mock(
+			async () =>
+				({
+					ok: true,
+					body: {
+						getReader: () => ({
+							read: async () => ({ done: true, value: undefined }),
+						}),
+					},
+				}) as unknown as Response,
+		) as unknown as typeof fetch;
+
+		await processSanctionedAddress(env);
+
+		const { results } = await db.prepare("SELECT * FROM sanctioned_addresses").all();
+		expect(results.length).toBe(0);
 	});
 });