Skip to content

Commit 99cdafa

Browse files
GRIF-326: Allow lcm bricks running with JRuby9.2
1 parent acb1955 commit 99cdafa

File tree

6 files changed

+40
-25
lines changed

6 files changed

+40
-25
lines changed

Dockerfile

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
FROM 020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-11-jre-centos9:202501070635.05b6a77
22

33
ARG RVM_VERSION=stable
4-
ARG JRUBY_VERSION=9.4.12.1
4+
ARG JRUBY_VERSION=9.2.21.0
55

66
LABEL image_name="GDC LCM Bricks"
77
LABEL maintainer="LCM <lcm@gooddata.com>"
88
LABEL git_repository_url="https://github.com/gooddata/gooddata-ruby/"
99
LABEL parent_image="020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-11-jre-centos9:202501070635.05b6a77"
1010

1111
# which is required by RVM
12-
RUN yum install -y gcc gcc-c++ which patch make unzip gnupg git maven procps gzip \
12+
RUN yum install -y gcc gcc-c++ diffutils curl-minimal which patch make git maven procps \
1313
&& yum clean all \
1414
&& rm -rf /var/cache/yum
1515

@@ -29,9 +29,11 @@ RUN curl -sSL https://rvm.io/mpapis.asc | gpg --import - \
2929
# Switch to a bash login shell to allow simple 'rvm' in RUN commands
3030
SHELL ["/bin/bash", "-l", "-c"]
3131

32-
RUN rvm install jruby-${JRUBY_VERSION} && gem update --system \
33-
&& gem install bundler -v 2.4.6 \
34-
&& gem install rake -v 13.0.6
32+
RUN rvm install jruby-${JRUBY_VERSION} \
33+
&& gem update --system 3.3.26 \
34+
&& gem install bundler -v 2.3.27 \
35+
&& gem install jruby-launcher -v 2.0.1 \
36+
&& gem install rake -v 11.3.0
3537

3638
WORKDIR /src
3739

Dockerfile.jruby

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
FROM jruby:9.4.12.1
1+
FROM jruby:9.2.5.0-alpine
22

33
MAINTAINER Tomas Korcak <korczis@gmail.com>
44

5-
RUN apt-get update && apt-get install -y curl make gcc git g++ python binutils-gold gnupg libstdc++6 cmake maven
5+
RUN apk add --no-cache curl make gcc git g++ python linux-headers binutils-gold gnupg libstdc++ cmake maven
66

77
# Switch to directory with sources
88
WORKDIR /src
99
ENV HOME=/src
1010
ENV BUNDLE_PATH=$HOME/bundle
1111

12-
RUN gem update --system \
13-
&& gem install --install-dir $BUNDLE_PATH bundler -v 2.4.6 \
14-
&& gem install --install-dir $BUNDLE_PATH rake -v 13.0.6
12+
RUN gem update --system 3.3.26 \
13+
&& gem install --install-dir $BUNDLE_PATH bundler -v 2.3.27 \
14+
&& gem install --install-dir $BUNDLE_PATH rake -v 11.3.0
1515

1616
ADD . .
1717

Dockerfile.ruby

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
1-
FROM ruby:3.2.1
1+
FROM ruby:2.5.1-alpine
22

33
MAINTAINER Tomas Korcak <korczis@gmail.com>
44

5-
RUN apt-get update && apt-get install -y curl make gcc git openssh-client g++ python binutils-gold gnupg libstdc++6 cmake
5+
RUN apk add --no-cache curl make gcc git g++ python linux-headers binutils-gold gnupg libstdc++ openssl cmake curl-dev
6+
7+
RUN ln -s /usr/bin/make /usr/bin/gmake
68

79
# Switch to directory with sources
810
WORKDIR /src
911
ENV HOME=/src
1012
ENV BUNDLE_PATH=$HOME/bundle
1113

12-
RUN gem update --system \
13-
&& gem install --install-dir $BUNDLE_PATH bundler -v 2.4.6 \
14-
&& gem install --install-dir $BUNDLE_PATH rake -v 13.0.6
14+
RUN gem update --system 3.3.26 \
15+
&& gem install --install-dir $BUNDLE_PATH bundler -v 2.3.27 \
16+
&& gem install --install-dir $BUNDLE_PATH rake -v 11.3.0
1517

1618
ADD . .
1719

gooddata.gemspec

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,32 @@ Gem::Specification.new do |s|
2828
# s.add_development_dependency 'bundler', "~> 1.14"
2929
s.add_development_dependency 'license_finder', '~> 2.0'
3030
s.add_development_dependency 'redcarpet', '~> 3.1' if RUBY_PLATFORM != 'java'
31-
s.add_development_dependency 'rspec', '~> 3.12.0'
32-
s.add_development_dependency 'rspec-expectations', '~> 3.12'
33-
s.add_development_dependency 'rspec_junit_formatter', '~> 0.6.0'
3431
if RUBY_VERSION >= '2.6'
3532
s.add_development_dependency 'rake', '~> 13.0'
3633
s.add_development_dependency 'rubocop', '>= 1.28'
3734
s.add_development_dependency 'rubocop-ast', '>= 1.24.1', '<= 1.42.0'
35+
s.add_development_dependency 'rspec', '~> 3.12.0'
36+
s.add_development_dependency 'rspec-expectations', '~> 3.12'
37+
s.add_development_dependency 'rspec_junit_formatter', '~> 0.6.0'
38+
39+
s.add_dependency 'azure-storage-blob', '~> 2.0'
40+
s.add_dependency 'nokogiri', '~> 1', '>= 1.10.8'
41+
s.add_dependency 'json_pure', '~> 2.6'
42+
s.add_dependency 'restforce', '>= 2.4'
43+
s.add_dependency 'rubyzip'
3844
else
3945
s.add_development_dependency 'rake', '~> 11.1'
4046
s.add_development_dependency 'rubocop', '~> 0.81'
47+
s.add_development_dependency 'rspec', '~> 3.5.0'
48+
s.add_development_dependency 'rspec-expectations', '~> 3.5'
49+
s.add_development_dependency 'rspec_junit_formatter', '~> 0.3.0'
50+
51+
s.add_dependency 'azure-storage-blob', '~> 1.1.0'
52+
s.add_dependency 'nokogiri', '~> 1.10.0'
53+
s.add_dependency 'json_pure', '~> 1.8'
54+
s.add_dependency 'restforce', '>= 2.4', '< 4.0'
55+
s.add_dependency 'rubyzip', '~> 1.2', '>= 1.2.1'
56+
s.add_dependency 'unf', '~> 0.1.4'
4157
end
4258
s.add_development_dependency 'simplecov', '~> 0.12'
4359
s.add_development_dependency 'webmock', '~> 2.3.1'
@@ -76,21 +92,16 @@ Gem::Specification.new do |s|
7692
else
7793
s.add_dependency 'docile', '> 1.1', '< 1.4.0'
7894
end
79-
s.add_dependency 'azure-storage-blob', '~> 2.0'
80-
s.add_dependency 'nokogiri', '~> 1', '>= 1.10.8'
8195
s.add_dependency 'gli', '~> 2.15'
8296
s.add_dependency 'gooddata_datawarehouse', '~> 0.0.12' if RUBY_PLATFORM == 'java'
8397
s.add_dependency 'highline', '= 2.0.0.pre.develop.14'
84-
s.add_dependency 'json_pure', '~> 2.6'
8598
s.add_dependency 'multi_json', '~> 1.12'
8699
s.add_dependency 'parseconfig', '~> 1.0'
87100
s.add_dependency 'path_expander', '< 1.1.2'
88101
s.add_dependency 'pmap', '~> 1.1'
89102
s.add_dependency 'sequel', '< 5.72.0'
90103
s.add_dependency 'remote_syslog_logger', '~> 1.0.3'
91-
s.add_dependency 'restforce', '>= 2.4'
92104
s.add_dependency 'rest-client', '~> 2.0'
93-
s.add_dependency 'rubyzip'
94105
s.add_dependency 'terminal-table', '~> 1.7'
95106
s.add_dependency 'thread_safe'
96107
s.add_dependency 'backports'

lib/gooddata/models/user_filters/user_filter_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def self.row_based?(options = {})
5151
end
5252

5353
def self.read_file(file, options = {})
54-
memo = Hash[]
54+
memo = {}
5555
if row_based?(options)
5656
read_data_without_header(file, memo, options)
5757
else

spec/unit/actions/synchronize_etls_in_segment_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@
326326
end
327327

328328
it 'parameters should be passed to the correct client project and schedule' do
329-
expect(schedule1).to receive(:update_params).once.ordered.with('HELLO': 'hi')
329+
expect(schedule1).to receive(:update_params).once.ordered.with('HELLO' => 'hi')
330330
subject.class.call(params)
331331
end
332332
end

0 commit comments

Comments
 (0)