Skip to content

Commit e08e690

Browse files
LukeBoyercopybara-github
authored andcommitted
Fix some random broken targets related to vendor device runtime tests.
LiteRT-PiperOrigin-RevId: 820533694
1 parent 0762a26 commit e08e690

File tree

8 files changed

+49
-21
lines changed

8 files changed

+49
-21
lines changed

litert/cc/BUILD

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ load("@rules_cc//cc:cc_test.bzl", "cc_test")
1818

1919
# copybara:uncomment load("@rules_cc//cc:objc_library.bzl", "objc_library")
2020
load("//litert/build_common:flavor_transition.bzl", "flavored_cc_alias")
21+
load("//litert/build_common:litert_build_defs.bzl", "cc_library_with_testonly_vis")
2122
load("//litert/build_common:special_rule.bzl", "gles_headers", "gles_linkopts", "litert_android_linkopts")
2223
load("//litert/integration_test:litert_device.bzl", "litert_device_exec", "litert_device_test")
2324
# copybara:uncomment load("@build_bazel_rules_apple//apple:ios.bzl", "ios_unit_test")
@@ -697,10 +698,10 @@ cc_test(
697698
],
698699
)
699700

700-
cc_library(
701+
cc_library_with_testonly_vis(
701702
name = "litert_environment",
702703
hdrs = ["litert_environment.h"],
703-
visibility = [
704+
vis = [
704705
# copybara:uncomment_begin(oss litert_lm)
705706
# "//litert:litert_cc_users_static_link",
706707
# copybara:uncomment_end_and_comment_begin
@@ -1055,10 +1056,10 @@ litert_device_exec(
10551056
target = ":litert_tensor_buffer_test",
10561057
)
10571058

1058-
cc_library(
1059+
cc_library_with_testonly_vis(
10591060
name = "litert_options",
10601061
hdrs = ["litert_options.h"],
1061-
visibility = [
1062+
vis = [
10621063
# copybara:uncomment_begin(oss litert_lm)
10631064
# "//litert:litert_cc_users_static_link",
10641065
# copybara:uncomment_end_and_comment_begin

litert/cc/litert_compiled_model_google_tensor_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
#include "litert/c/litert_event_type.h"
2828
#include "litert/c/litert_gl_types.h"
2929
#include "litert/c/litert_tensor_buffer_types.h"
30+
#include "litert/cc/internal/litert_platform_support.h"
3031
#include "litert/cc/litert_compiled_model.h"
3132
#include "litert/cc/litert_environment.h"
3233
#include "litert/cc/litert_event.h"
3334
#include "litert/cc/litert_model.h"
34-
#include "litert/cc/litert_platform_support.h"
3535
#include "litert/cc/litert_tensor_buffer.h"
3636
#include "litert/test/common.h"
3737
#include "litert/test/matchers.h"

litert/integration_test/BUILD

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ litert_device_test(
162162
backend_id = "mediatek",
163163
deps = [
164164
"//litert/cc:litert_shared_library",
165+
"//litert/cc/options:litert_mediatek_options",
166+
"//litert/test:matchers",
165167
"//litert/vendors/mediatek:neuron_adapter_api",
166168
"@com_google_googletest//:gtest_main",
167169
],
@@ -209,7 +211,8 @@ litert_device_test(
209211
#
210212
# GOOGLE_TENSOR_GUITAR_TARGS_SMALL = [
211213
# ":google_tensor_smoketest",
212-
# "//litert/runtime/dispatch:dispatch_delegate_google_tensor_test",
214+
# # TODO: lukeboyer - Reenable once vis is updated.
215+
# # "//litert/runtime/dispatch:dispatch_delegate_google_tensor_test",
213216
# "//litert/runtime/dispatch:dispatch_delegate_cascade_google_tensor_test",
214217
# "//litert/runtime/dispatch:dispatch_delegate_mixed_cascade_google_tensor_test",
215218
# "//litert/cc:litert_compiled_model_gpu_device_test",

litert/integration_test/smoketests/mediatek_smoketest.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
#include <gtest/gtest.h>
2020
#include "litert/cc/litert_shared_library.h"
21+
#include "litert/cc/options/litert_mediatek_options.h"
22+
#include "litert/test/matchers.h"
2123
#include "litert/vendors/mediatek/neuron_adapter_api.h"
2224

2325
namespace litert::test {
@@ -42,8 +44,9 @@ TEST(MediaTekSmokeTest, LoadLibsFromEnvPath) {
4244
}
4345

4446
TEST(MediaTekSmokeTest, NeuronAdapterApiCreate) {
45-
auto neuron_adapter_api =
46-
litert::mediatek::NeuronAdapterApi::Create(std::nullopt);
47+
auto mediatek_options = mediatek::MediatekOptions::Create();
48+
auto neuron_adapter_api = litert::mediatek::NeuronAdapterApi::Create(
49+
std::nullopt, mediatek_options);
4750
ASSERT_TRUE(neuron_adapter_api.HasValue());
4851
}
4952

litert/runtime/dispatch/BUILD

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,15 @@ litert_device_test(
192192
"//conditions:default": [],
193193
}),
194194
linkopts = gles_linkopts(),
195+
# TODO: gt team update visibility.
196+
tags = [
197+
"nobuilder",
198+
"notap",
199+
],
195200
deps = [
196201
":dispatch_delegate",
197202
":dispatch_opaque_options",
203+
"//platforms/darwinn/tachyon/core/fence",
198204
"@com_google_googletest//:gtest_main",
199205
"@com_google_absl//absl/log",
200206
"@com_google_absl//absl/log:absl_log",
@@ -207,16 +213,14 @@ litert_device_test(
207213
"//litert/cc:litert_environment",
208214
"//litert/cc:litert_event",
209215
"//litert/cc:litert_expected",
210-
"//litert/cc/dynamic_runtime:litert_compiled_model",
211-
"//litert/cc/dynamic_runtime:litert_environment",
212-
"//litert/cc/dynamic_runtime:litert_event",
213216
"//litert/cc/dynamic_runtime:litert_model",
214217
"//litert/cc/dynamic_runtime:litert_options",
215218
"//litert/cc/dynamic_runtime:litert_tensor_buffer",
216-
"//litert/core/model:model_buffer",
217219
"//litert/core/util:flatbuffer_tools",
218220
"//litert/runtime:external_litert_buffer_context",
219221
"//litert/runtime:tensor_buffer",
222+
"//litert/runtime:tensor_identifier",
223+
"//litert/runtime:tfl_utils",
220224
"//litert/test:common",
221225
"//litert/test:matchers",
222226
"//litert/test:simple_model_npu",

litert/vendors/google_tensor/dispatch/BUILD

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,11 @@ litert_device_test(
9595
"//litert/test:testdata/simple_model_google_tensor.bin",
9696
"//litert/test:testdata/simple_model_npu.tflite",
9797
],
98+
# TODO: google_tensor team fix visibility for fence deps.
99+
tags = [
100+
"nobuilder",
101+
"notap",
102+
],
98103
deps = [
99104
"//litert/c:litert_runtime_c_api_shared_lib",
100105
"//litert/cc:litert_expected",
@@ -124,6 +129,11 @@ litert_device_test(
124129
"//tools/cc_target_os:android": ["-layering_check"],
125130
"//conditions:default": [],
126131
}),
132+
# TODO: google_tensor team fix visibility for fence deps.
133+
tags = [
134+
"nobuilder",
135+
"notap",
136+
],
127137
deps = [
128138
"@com_google_googletest//:gtest_main",
129139
"@com_google_absl//absl/log",

litert/vendors/mediatek/dispatch/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ litert_device_test(
8989
":dispatch_api",
9090
"//litert/c:litert_runtime_c_api_shared_lib",
9191
"//litert/cc:litert_any",
92-
"//litert/cc:litert_environment",
93-
"//litert/cc/internal:litert_options",
92+
"//litert/cc:litert_environment_testonly",
93+
"//litert/cc:litert_options_testonly",
9494
"//litert/core:filesystem_testonly",
9595
"//litert/test:common",
9696
"//litert/test:matchers",

litert/vendors/mediatek/dispatch/dispatch_api_mediatek_test.cc

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,8 @@ TEST(MediaTek, DispatchApiWithAhwb) {
312312
{
313313
ABSL_LOG(INFO) << "Checking output...";
314314
void* host_mem_addr;
315-
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr),
315+
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr,
316+
kLiteRtTensorBufferLockModeRead),
316317
kLiteRtStatusOk);
317318
auto output = absl::MakeSpan(static_cast<const float*>(host_mem_addr),
318319
kTestOutputSize);
@@ -543,12 +544,14 @@ TEST(MediaTek, DispatchApiWithDmaBuf) {
543544
ABSL_LOG(INFO) << "Filling inputs with data";
544545
void* host_mem_addr;
545546

546-
ASSERT_EQ(LiteRtLockTensorBuffer(input_0_tensor_buffer, &host_mem_addr),
547+
ASSERT_EQ(LiteRtLockTensorBuffer(input_0_tensor_buffer, &host_mem_addr,
548+
kLiteRtTensorBufferLockModeRead),
547549
kLiteRtStatusOk);
548550
std::memcpy(host_mem_addr, kTestInput0Tensor, sizeof(kTestInput0Tensor));
549551
ASSERT_EQ(LiteRtUnlockTensorBuffer(input_0_tensor_buffer), kLiteRtStatusOk);
550552

551-
ASSERT_EQ(LiteRtLockTensorBuffer(input_1_tensor_buffer, &host_mem_addr),
553+
ASSERT_EQ(LiteRtLockTensorBuffer(input_1_tensor_buffer, &host_mem_addr,
554+
kLiteRtTensorBufferLockModeRead),
552555
kLiteRtStatusOk);
553556
std::memcpy(host_mem_addr, kTestInput1Tensor, sizeof(kTestInput1Tensor));
554557
ASSERT_EQ(LiteRtUnlockTensorBuffer(input_1_tensor_buffer), kLiteRtStatusOk);
@@ -568,7 +571,8 @@ TEST(MediaTek, DispatchApiWithDmaBuf) {
568571
{
569572
ABSL_LOG(INFO) << "Checking output...";
570573
void* host_mem_addr;
571-
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr),
574+
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr,
575+
kLiteRtTensorBufferLockModeRead),
572576
kLiteRtStatusOk);
573577
auto output = absl::MakeSpan(static_cast<const float*>(host_mem_addr),
574578
kTestOutputSize);
@@ -587,13 +591,15 @@ TEST(MediaTek, DispatchApiWithDmaBuf) {
587591
ABSL_LOG(INFO) << "Filling inputs with data";
588592
void* host_mem_addr;
589593

590-
ASSERT_EQ(LiteRtLockTensorBuffer(input_0_tensor_buffer, &host_mem_addr),
594+
ASSERT_EQ(LiteRtLockTensorBuffer(input_0_tensor_buffer, &host_mem_addr,
595+
kLiteRtTensorBufferLockModeRead),
591596
kLiteRtStatusOk);
592597
std::memcpy(host_mem_addr, kTestInput0Tensor_2,
593598
sizeof(kTestInput0Tensor_2));
594599
ASSERT_EQ(LiteRtUnlockTensorBuffer(input_0_tensor_buffer), kLiteRtStatusOk);
595600

596-
ASSERT_EQ(LiteRtLockTensorBuffer(input_1_tensor_buffer, &host_mem_addr),
601+
ASSERT_EQ(LiteRtLockTensorBuffer(input_1_tensor_buffer, &host_mem_addr,
602+
kLiteRtTensorBufferLockModeRead),
597603
kLiteRtStatusOk);
598604
std::memcpy(host_mem_addr, kTestInput1Tensor_2,
599605
sizeof(kTestInput1Tensor_2));
@@ -614,7 +620,8 @@ TEST(MediaTek, DispatchApiWithDmaBuf) {
614620
{
615621
ABSL_LOG(INFO) << "Checking output...";
616622
void* host_mem_addr;
617-
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr),
623+
ASSERT_EQ(LiteRtLockTensorBuffer(output_tensor_buffer, &host_mem_addr,
624+
kLiteRtTensorBufferLockModeRead),
618625
kLiteRtStatusOk);
619626
auto output = absl::MakeSpan(static_cast<const float*>(host_mem_addr),
620627
kTestOutputSize);

0 commit comments

Comments
 (0)