Skip to content

feat(ErdosProblems): 260#1629

Open
VikaBrikule wants to merge 9 commits intogoogle-deepmind:mainfrom
VikaBrikule:Erdos_260
Open

feat(ErdosProblems): 260#1629
VikaBrikule wants to merge 9 commits intogoogle-deepmind:mainfrom
VikaBrikule:Erdos_260

Conversation

@VikaBrikule
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Jan 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the erdos-problems Erdős Problems label Jan 12, 2026
Added copyright.
@VikaBrikule VikaBrikule changed the title Create 260 feat(ErdosProblem): 260 Jan 12, 2026
@CBirkbeck
Copy link
Contributor

You need to sign the CLA

-Changed import
-Added the attribute
-Changed to using Irrational
@VikaBrikule VikaBrikule marked this pull request as ready for review January 20, 2026 12:16
Copy link
Member

@Paul-Lez Paul-Lez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - a few comments! When you're done addressing these, don't forget to check that everything builds locally by using lake build.

VikaBrikule and others added 2 commits January 20, 2026 12:44
Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
VikaBrikule and others added 2 commits January 20, 2026 12:46
Co-authored-by: Paul Lezeau <paul.lezeau@gmail.com>
inlined the two definitions and made use of HasSum
@YaelDillies YaelDillies changed the title feat(ErdosProblem): 260 feat(ErdosProblems): 260 Jan 21, 2026
@CBirkbeck
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

erdos-problems Erdős Problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants