Skip to content

fix(ErdosProblems): Add formalized lean sources to Erdos Problems#2383

Merged
mo271 merged 5 commits intogoogle-deepmind:mainfrom
danielchin:add-lean
Feb 25, 2026
Merged

fix(ErdosProblems): Add formalized lean sources to Erdos Problems#2383
mo271 merged 5 commits intogoogle-deepmind:mainfrom
danielchin:add-lean

Conversation

@danielchin
Copy link
Contributor

@danielchin danielchin commented Feb 23, 2026

Adding formalized lean sources.

There's a few exceptions that I've caught:

  1. 303 was actually written in lean3 and the only category annotation is lean4. Maybe we add a lean3 annotation?
  2. The URL for 303 is actually way too long, even for URL shorteners because it's using live.looken.cn. I'm leaving this out for now until we figure how we want to reference it.

Also took the liberty to fix up some of the docstrings and references.

Closes #2334
Closes #2335
Closes #2336
Closes #2337
Closes #2338
Closes #2339
Closes #2340
Closes #2341
Closes #2342
Closes #2343
Closes #2344
Closes #2345
Closes #2346
Closes #2347
Closes #2348
Closes #2349
Closes #2350
Closes #2351
Closes #2352
Closes #2353
Closes #2354
Closes #2355

@github-actions github-actions bot added the erdos-problems Erdős Problems label Feb 23, 2026
@mo271
Copy link
Collaborator

mo271 commented Feb 23, 2026

Adding formalized lean sources.

There's a few exceptions that I've caught:

  1. 303 was actually written in lean3 and the only category annotation is lean4. Maybe we add a lean3 annotation?

No, let's just use the FormalProofKind called otherSystem.

  1. The URL for 303 is actually way too long, even for URL shorteners because it's using live.looken.cn. I'm leaving this out for now until we figure how we want to reference it.

In this case let's just "link to the link", namely link to https://www.erdosproblems.com/forum/thread/303

Also took the liberty to fix up some of the docstrings and references.

Great!

Copy link
Collaborator

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great, @danielchin: let's also fix the URL 303 as described in the comment above, otherwise this is good to go!

@danielchin
Copy link
Contributor Author

Oops, looks like I misspoke, 289 and 299 were the ones that were written in lean3, so updated those to say other_system.

@mo271 mo271 merged commit f5cbb7c into google-deepmind:main Feb 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment