feat(Wikipedia): add ERH for Dedekind zeta#2402
feat(Wikipedia): add ERH for Dedekind zeta#2402Robertboy18 wants to merge 4 commits intogoogle-deepmind:mainfrom
Conversation
Paul-Lez
left a comment
There was a problem hiding this comment.
Thanks for the contribution! One minor comment - I'll take a look at the maths later on:)
| *Reference:* [Wikipedia](https://en.wikipedia.org/wiki/Generalized_Riemann_hypothesis) | ||
| -/ | ||
|
|
||
| namespace ERH |
There was a problem hiding this comment.
Generally, we tend to use the file name for the namespace (or something similar), so here I'd suggest the following:
| namespace ERH | |
| namespace ExtendedRiemannHypothesis |
There was a problem hiding this comment.
Good catch! updated the namespace to ExtendedRiemannHypothesis to match the file name. Thanks!
|
In #2378 it is proposed that we use the file |
|
Thanks for the review and I agree! That was totally my bad I didn't check more - I had just formalized what i thought was good from one of my ugrad classes concepts and should have done more literature study! I’ve strengthened the main Lean statement to quantify over all zeros of ζ_K, excluding the trivial zeros (via I also kept the “critical strip” formulation as a derived lemma and added clearer references/comments. Thanks! |
Pushed #2376 by adding a Lean statement of the ERH for Dedekind zeta functions, using Mathlib’s
NumberField.dedekindZeta(zeros in0 < Re(s) < 1lie onRe(s) = 1/2)! Let me know what changes are needed.