Skip to content

Commit 3cb6fac

Browse files
committed
Name wheels workflow differently and exclude 4P quoridor from tests
1 parent 88dfd4a commit 3cb6fac

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/wheels.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,13 @@ on:
2323

2424
jobs:
2525
build_wheels:
26-
name: Build wheels on ${{ matrix.os }}
26+
name: Build wheels on ${{ matrix.os }} ${{ matrix.NAME }}
2727
runs-on: ${{ matrix.os }}
2828
strategy:
2929
matrix:
3030
include:
3131
- os: ubuntu-22.04
32+
NAME: "Linux"
3233
OS_TYPE: "Linux"
3334
CI_PYBIN: python3
3435
OS_PYTHON_VERSION: 3.10
@@ -37,6 +38,7 @@ jobs:
3738
CIBW_BUILD: cp39-manylinux_x86_64 cp310-manylinux_x86_64 cp311-manylinux_x86_64 cp312-manylinux_x86_64 cp313-manylinux_x86_64
3839
# These must use the old abseil
3940
- os: macOS-13
41+
NAME: "MacOS-13 Python <= 3.11"
4042
OS_TYPE: "Darwin"
4143
CI_PYBIN: python3.9
4244
OS_PYTHON_VERSION: 3.9
@@ -45,6 +47,7 @@ jobs:
4547
CIBW_BUILD: cp39-macosx_x86_64 cp310-macosx_x86_64 cp311-macosx_x86_64
4648
# These use the new abseil
4749
- os: macOS-13
50+
NAME: "MacOS-13 Python >= 3.12"
4851
OS_TYPE: "Darwin"
4952
CI_PYBIN: python3.12
5053
OPEN_SPIEL_ABSL_VERSION: "20250127.1"

open_spiel/python/tests/games_sim_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,10 @@ def test_multiplayer_game(self, game_info, num_players):
245245
"reward_matrix": " ".join(str(v) for v in reward_matrix.flatten()),
246246
"init_distrib": " ".join(str(v) for v in init_distrib.flatten()),
247247
}
248+
elif game_info.short_name == "quoridor" and num_players == 4:
249+
print("Skipping 4P Quoridor in tests as it has known problems.")
250+
print("See https://github.com/google-deepmind/open_spiel/issues/1349")
251+
return
248252
else:
249253
dict_args = {"players": num_players}
250254
game = pyspiel.load_game(game_info.short_name, dict_args)

0 commit comments

Comments
 (0)