Non-deterministic segfault in games_sim_test.py on Dou Dizhu

[lanctot]

https://github.com/google-deepmind/open_spiel/actions/runs/16790943210

Seems to only happen when testing the wheels and only in Python 3.10. Probably a memory issue of some kind.

[ RUN      ] GamesSimTest.test_game_sim_dou_dizhu
  Fatal Python error: Segmentation fault
  
  Current thread 0x00007ff85e0b9a00 (most recent call first):
    File "/Users/runner/work/open_spiel/open_spiel/open_spiel/python/tests/games_sim_test.py", line 91 in apply_action_test_clone
    File "/Users/runner/work/open_spiel/open_spiel/open_spiel/python/tests/games_sim_test.py", line 174 in sim_game
    File "/Users/runner/work/open_spiel/open_spiel/open_spiel/python/tests/games_sim_test.py", line 210 in test_game_sim
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/parameterized.py", line 323 in bound_param_test
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 549 in _callTestMethod
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 591 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 650 in __call__
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/suite.py", line 122 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/suite.py", line 84 in __call__
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/suite.py", line 122 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/suite.py", line 84 in __call__
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/runner.py", line 184 in run
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/_pretty_print_reporter.py", line 84 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/main.py", line 271 in runTests
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/main.py", line 101 in __init__
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/absltest.py", line 2821 in _run_and_get_tests_result
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/absltest.py", line 2857 in run_tests
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/absltest.py", line 2362 in _run_in_app
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/testing/absltest.py", line 2266 in main
    File "/Users/runner/work/open_spiel/open_spiel/open_spiel/python/tests/games_sim_test.py", line 419 in main
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/app.py", line 261 in _run_main
    File "/private/var/folders/vk/nx37ffx50hv5djclhltc26vw0000gn/T/cibw-run-gc9ee5mi/cp310-macosx_x86_64/venv-test-x86_64/lib/python3.10/site-packages/absl/app.py", line 316 in run
    File "/Users/runner/work/open_spiel/open_spiel/open_spiel/python/tests/games_sim_test.py", line 424 in <module>
  
  Extension modules: numpy._core._multiarray_umath, numpy.linalg._umath_linalg, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._mt19937, numpy.random.mtrand, numpy.random._philox, numpy.random._pcg64, numpy.random._sfc64, numpy.random._generator, yaml._yaml, scipy._lib._ccallback_c, scipy.sparse._sparsetools, _csparsetools, scipy.sparse._csparsetools, scipy.linalg._fblas, scipy.linalg._flapack, scipy.linalg.cython_lapack, scipy.linalg._cythonized_array_utils, scipy.linalg._solve_toeplitz, scipy.linalg._decomp_lu_cython, scipy.linalg._matfuncs_sqrtm_triu, scipy.linalg._matfuncs_expm, scipy.linalg._linalg_pythran, scipy.linalg.cython_blas, scipy.linalg._decomp_update, scipy.sparse.linalg._dsolve._superlu, scipy.sparse.linalg._eigen.arpack._arpack, scipy.sparse.linalg._propack._spropack, scipy.sparse.linalg._propack._dpropack, scipy.sparse.linalg._propack._cpropack, scipy.sparse.linalg._propack._zpropack, scipy.sparse.csgraph._tools, scipy.sparse.csgraph._shortest_path, scipy.sparse.csgraph._traversal, scipy.sparse.csgraph._min_spanning_tree, scipy.sparse.csgraph._flow, scipy.sparse.csgraph._matching, scipy.sparse.csgraph._reordering, scipy.spatial._ckdtree, scipy._lib.messagestream, scipy.spatial._qhull, scipy.spatial._voronoi, scipy.spatial._distance_wrap, scipy.spatial._hausdorff, scipy.special._ufuncs_cxx, scipy.special._ufuncs, scipy.special._specfun, scipy.special._comb, scipy.special._ellip_harm_2, scipy.spatial.transform._rotation, scipy.optimize._group_columns, scipy.optimize._trlib._trlib, scipy.optimize._lbfgsb, _moduleTNC, scipy.optimize._moduleTNC, scipy.optimize._cobyla, scipy.optimize._slsqp, scipy.optimize._minpack, scipy.optimize._lsq.givens_elimination, scipy.optimize._zeros, scipy.optimize._cython_nnls, scipy._lib._uarray._uarray, scipy.linalg._decomp_interpolative, scipy.optimize._bglu_dense, scipy.optimize._lsap, scipy.optimize._direct, scipy.integrate._odepack, scipy.integrate._quadpack, scipy.integrate._vode, scipy.integrate._dop, scipy.integrate._lsoda, scipy.interpolate._fitpack, scipy.interpolate._dfitpack, scipy.interpolate._dierckx, scipy.interpolate._ppoly, scipy.interpolate._interpnd, scipy.interpolate._rbfinterp_pythran, scipy.interpolate._rgi_cython, scipy.interpolate._bspl, scipy.special.cython_special, scipy.stats._stats, scipy.stats._sobol, scipy.stats._qmc_cy, scipy.stats._biasedurn, scipy.stats._stats_pythran, scipy.stats._levy_stable.levyst, scipy.stats._ansari_swilk_statistics, scipy.stats._mvn, scipy.stats._rcont.rcont, scipy.ndimage._nd_image, scipy.ndimage._rank_filter_1d, _ni_label, scipy.ndimage._ni_label (total: 95)
  
  87/95 Test #222: python/tests/pyspiel_test.py ...............................   Passed   50.95 sec
  88/95 Test #205: python/mfg/games/dynamic_routing_test.py ...................   Passed   70.24 sec
  89/95 Test #221: python/tests/policy_test.py ................................   Passed   52.33 sec
  90/95 Test #194: python/games/dynamic_routing_test.py .......................   Passed  117.38 sec
  91/95 Test #149: python/algorithms/best_response_test.py ....................   Passed  172.61 sec
  92/95 Test #224: python/tests/sampled_stochastic_games_test.py ..............   Passed   59.27 sec
  93/95 Test #155: python/algorithms/efr_test.py ..............................   Passed  186.11 sec
  94/95 Test #207: python/tests/mfg_implementation_test/mfg_test.py ...........   Passed   90.31 sec
  95/95 Test #145: python/../integration_tests/api_test.py ....................   Passed  194.86 sec
  
  99% tests passed, 1 tests failed out of 95
  
  Total Test time (real) = 194.93 sec
  
  The following tests FAILED:
  	219 - python/tests/games_sim_test.py (SEGFAULT)
  Errors while running CTest
  Error: Command ['/bin/sh', '-c', '/bin/bash /Users/runner/work/open_spiel/open_spiel/open_spiel/scripts/test_wheel.sh basic /Users/runner/work/open_spiel/open_spiel'] failed with code 8. 

                                                            ✕ 232.77s
Error: Process completed with exit code 1.

[alexunderch]

Linux builds don't fail by themselves, as I see mostly macOS failures.
Didn't you investigate into recent libraries upgrades (e.g. abseil)?

[lanctot]

I haven't looked into this at all as it's quite low-priority at the moment and I'm swamped. I suspect a memory issue in Dou Dizhu, which may get found if compiling + running with memory checkers. Just wanted to flag to justify disabling the test for a release that we have to put out soon.