fix list initialization and redundant parentheses (#412)

* update_time defined twice hence removing once.

* removed redundant parentheses from some test cases

* removed multi-step list initialization

* Removed unused import

* Revert "Removed unused import"

This reverts commit d1e6012.

* fix black issue

Author: PandasPirate

google/generativeai/notebook/sheets_utils.py

@@ -102,8 +102,7 @@ def __init__(self, sid: sheets_id.SheetsIdentifier):
     def write_outputs(self, outputs: llmfn_outputs.LLMFnOutputsBase) -> None:
         # Transpose `outputs` into a list of rows.
         outputs_dict = outputs.as_dict()
-        outputs_rows: list[Sequence[Any]] = []
-        outputs_rows.append(list(outputs_dict.keys()))
+        outputs_rows: list[Sequence[Any]] = [list(outputs_dict.keys())]
         outputs_rows.extend([list(x) for x in zip(*outputs_dict.values())])
 
         gspread_client.get_client().write_records(

tests/notebook/test_cmd_line_parser.py

@@ -51,7 +51,7 @@ def _set_output_sink(text_result: str, sink: llmfn_outputs.LLMFnOutputsSink) ->
                         llmfn_output_row.LLMFnOutputRow(
                             data={
                                 llmfn_outputs.ColumnNames.RESULT_NUM: 0,
-                                llmfn_outputs.ColumnNames.TEXT_RESULT: (text_result),
+                                llmfn_outputs.ColumnNames.TEXT_RESULT: text_result,
                             },
                             result_type=str,
                         )

tests/notebook/test_sheets_sanitize_url.py

@@ -38,7 +38,7 @@ def test_domain_must_be_docs_google_com(self):
         """Domain must be docs.google.com."""
         with self.assertRaisesRegex(
             ValueError,
-            ('Domain for Sheets url must be "docs.google.com", got' ' "sheets.google.com"'),
+            'Domain for Sheets url must be "docs.google.com", got' ' "sheets.google.com"',
         ):
             sanitize_sheets_url("https://sheets.google.com")
 

tests/test_generation.py

@@ -116,7 +116,7 @@ def test_join_contents(self):
         result = generation_types._join_contents(contents)
         expected = {
             "parts": [
-                {"text": ("Tell me a story about a magic backpack that looks like" " this: ")},
+                {"text": "Tell me a story about a magic backpack that looks like" " this: "},
                 {"inline_data": {"mime_type": "image/png", "data": "REFUQSE="}},
             ],
             "role": "assistant",
@@ -254,7 +254,7 @@ def test_join_candidates(self):
         expected = {
             "content": {
                 "parts": [
-                    {"text": ("Tell me a story about a magic backpack that looks like" " this: ")},
+                    {"text": "Tell me a story about a magic backpack that looks like" " this: "},
                     {"text": ""},
                 ],
                 "role": "assistant",
@@ -438,7 +438,7 @@ def test_join_prompt_feedbacks(self):
         {
             "content": {
                 "parts": [
-                    {"text": ("Tell me a story about a magic backpack" " that looks like this: ")},
+                    {"text": "Tell me a story about a magic backpack" " that looks like this: "},
                     {
                         "inline_data": {
                             "mime_type": "image/png",