Skip to content

Commit 50ed7db

Browse files
committed
Remove seed (it doesn't work without watermark), +fix upscale
Change-Id: I4c394cd861d2646cd663224f0bbeec52580bc0bd
1 parent 01cd06d commit 50ed7db

File tree

1 file changed

+9
-18
lines changed

1 file changed

+9
-18
lines changed

google/generativeai/vision_models/_vision_models.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ class ImageGenerationModel:
201201
prompt="Astronaut riding a horse",
202202
# Optional:
203203
number_of_images=1,
204-
seed=0,
205204
)
206205
response[0].show()
207206
response[0].save("image1.png")
@@ -228,7 +227,6 @@ def _generate_images(
228227
height: Optional[int] = None,
229228
aspect_ratio: Optional[Literal["1:1", "9:16", "16:9", "4:3", "3:4"]] = None,
230229
guidance_scale: Optional[float] = None,
231-
seed: Optional[int] = None,
232230
base_image: Optional["Image"] = None,
233231
mask: Optional["Image"] = None,
234232
edit_mode: Optional[
@@ -269,7 +267,6 @@ def _generate_images(
269267
guidance_scale: Controls the strength of the prompt. Suggested values
270268
are - * 0-9 (low strength) * 10-20 (medium strength) * 21+ (high
271269
strength)
272-
seed: Image generation random seed.
273270
base_image: Base image to use for the image generation.
274271
mask: Mask for the base image.
275272
edit_mode: Describes the editing mode for the request. Supported values
@@ -361,11 +358,6 @@ class ID
361358
parameters["negativePrompt"] = negative_prompt
362359
shared_generation_parameters["negative_prompt"] = negative_prompt
363360

364-
if seed is not None:
365-
# Note: String seed and numerical seed give different results
366-
parameters["seed"] = seed
367-
shared_generation_parameters["seed"] = seed
368-
369361
if guidance_scale is not None:
370362
parameters["guidanceScale"] = guidance_scale
371363
shared_generation_parameters["guidance_scale"] = guidance_scale
@@ -444,7 +436,6 @@ def generate_images(
444436
aspect_ratio: Optional[Literal["1:1", "9:16", "16:9", "4:3", "3:4"]] = None,
445437
guidance_scale: Optional[float] = None,
446438
language: Optional[str] = None,
447-
seed: Optional[int] = None,
448439
safety_filter_level: Optional[
449440
Literal["block_most", "block_some", "block_few", "block_fewest"]
450441
] = None,
@@ -472,7 +463,6 @@ def generate_images(
472463
Supported values are `"en"` for English, `"hi"` for Hindi, `"ja"`
473464
for Japanese, `"ko"` for Korean, and `"auto"` for automatic language
474465
detection.
475-
seed: Image generation random seed.
476466
safety_filter_level: Adds a filter level to Safety filtering. Supported
477467
values are:
478468
* "block_most" : Strongest filtering level, most strict
@@ -495,7 +485,6 @@ def generate_images(
495485
aspect_ratio=aspect_ratio,
496486
guidance_scale=guidance_scale,
497487
language=language,
498-
seed=seed,
499488
safety_filter_level=safety_filter_level,
500489
person_generation=person_generation,
501490
)
@@ -519,7 +508,6 @@ def edit_image(
519508
output_mime_type: Optional[Literal["image/png", "image/jpeg"]] = None,
520509
compression_quality: Optional[float] = None,
521510
language: Optional[str] = None,
522-
seed: Optional[int] = None,
523511
safety_filter_level: Optional[
524512
Literal["block_most", "block_some", "block_few", "block_fewest"]
525513
] = None,
@@ -573,7 +561,6 @@ class ID
573561
Supported values are `"en"` for English, `"hi"` for Hindi,
574562
`"ja"` for Japanese, `"ko"` for Korean, and `"auto"` for
575563
automatic language detection.
576-
seed: Image generation random seed.
577564
safety_filter_level: Adds a filter level to Safety filtering. Supported
578565
values are:
579566
* "block_most" : Strongest filtering level, most strict
@@ -595,7 +582,6 @@ class ID
595582
negative_prompt=negative_prompt,
596583
number_of_images=number_of_images,
597584
guidance_scale=guidance_scale,
598-
seed=seed,
599585
base_image=base_image,
600586
mask=mask,
601587
edit_mode=edit_mode,
@@ -613,7 +599,7 @@ class ID
613599
def upscale_image(
614600
self,
615601
image: Union["Image", "GeneratedImage"],
616-
new_size: Optional[int] = 2048,
602+
new_size: Optional[int] = None,
617603
upscale_factor: Optional[Literal["x2", "x4"]] = None,
618604
output_mime_type: Optional[Literal["image/png", "image/jpeg"]] = "image/png",
619605
output_compression_quality: Optional[int] = None,
@@ -664,6 +650,9 @@ def upscale_image(
664650
Returns:
665651
An `Image` object.
666652
"""
653+
if self._client is None:
654+
self._client = client.get_default_prediction_client()
655+
667656
target_image_size = new_size if new_size else None
668657
longest_dim = max(image._size[0], image._size[1])
669658

@@ -714,10 +703,12 @@ def upscale_image(
714703
if output_mime_type == "image/jpeg" and output_compression_quality is not None:
715704
parameters["outputOptions"]["compressionQuality"] = output_compression_quality
716705

717-
response = self._endpoint.predict(
718-
instances=[to_value(instance)],
719-
parameters=parameters,
706+
707+
pr = protos.PredictRequest.pb()
708+
request = pr(
709+
model=self.model_name, instances=[to_value(instance)], parameters=to_value(parameters)
720710
)
711+
response = self._client.predict(request)
721712

722713
upscaled_image = response.predictions[0]
723714

0 commit comments

Comments
 (0)