Skip to content

Commit 2c3c861

Browse files
committed
fix: resolve IDE parameter mismatches and ensure memory tool security
1 parent 88cced0 commit 2c3c861

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/core/src/tools/memoryTool.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,14 +310,13 @@ export class MemoryTool
310310
static readonly Name = MEMORY_TOOL_NAME;
311311

312312
constructor(messageBus: MessageBus) {
313-
// Standard initialization for MemoryTool with messageBus for confirmation
313+
// Initialize the tool with its specific properties
314314
super(
315315
MemoryTool.Name,
316316
'SaveMemory',
317317
memoryToolDescription,
318318
Kind.Think,
319319
memoryToolSchemaData.parametersJsonSchema as Record<string, unknown>,
320-
// @ts-expect-error - The IDE incorrectly shifts parameter positions in the constructor hierarchy, but runtime/tsc are correct
321320
messageBus,
322321
true,
323322
false,

packages/core/src/utils/memoryDiscovery.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {
2020
DEFAULT_CONTEXT_FILENAME,
2121
} from '../tools/memoryTool.js';
2222
import { FileDiscoveryService } from '../services/fileDiscoveryService.js';
23-
// @ts-expect-error - The IDE incorrectly identifies this as missing, but it exists and tests pass
2423
import { GEMINI_DIR, homedir as pathsHomedir } from './paths.js';
2524
import { Config, type GeminiCLIExtension } from '../config/config.js';
2625
import { Storage } from '../config/storage.js';

0 commit comments

Comments
 (0)