Improve code coverage for cli package (#13724)

Author: megha1188

packages/cli/src/__snapshots__/nonInteractiveCli.test.ts.snap

@@ -1,5 +1,32 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
+exports[`runNonInteractive > should emit appropriate error event in streaming JSON mode: 'loop detected' 1`] = `
+"{"type":"init","timestamp":"<TIMESTAMP>","session_id":"test-session-id","model":"test-model"}
+{"type":"message","timestamp":"<TIMESTAMP>","role":"user","content":"Loop test"}
+{"type":"error","timestamp":"<TIMESTAMP>","severity":"warning","message":"Loop detected, stopping execution"}
+{"type":"result","timestamp":"<TIMESTAMP>","status":"success","stats":{"total_tokens":0,"input_tokens":0,"output_tokens":0,"duration_ms":<DURATION>,"tool_calls":0}}
+"
+`;
+
+exports[`runNonInteractive > should emit appropriate error event in streaming JSON mode: 'max session turns' 1`] = `
+"{"type":"init","timestamp":"<TIMESTAMP>","session_id":"test-session-id","model":"test-model"}
+{"type":"message","timestamp":"<TIMESTAMP>","role":"user","content":"Max turns test"}
+{"type":"error","timestamp":"<TIMESTAMP>","severity":"error","message":"Maximum session turns exceeded"}
+{"type":"result","timestamp":"<TIMESTAMP>","status":"success","stats":{"total_tokens":0,"input_tokens":0,"output_tokens":0,"duration_ms":<DURATION>,"tool_calls":0}}
+"
+`;
+
+exports[`runNonInteractive > should emit appropriate events for streaming JSON output 1`] = `
+"{"type":"init","timestamp":"<TIMESTAMP>","session_id":"test-session-id","model":"test-model"}
+{"type":"message","timestamp":"<TIMESTAMP>","role":"user","content":"Stream test"}
+{"type":"message","timestamp":"<TIMESTAMP>","role":"assistant","content":"Thinking...","delta":true}
+{"type":"tool_use","timestamp":"<TIMESTAMP>","tool_name":"testTool","tool_id":"tool-1","parameters":{"arg1":"value1"}}
+{"type":"tool_result","timestamp":"<TIMESTAMP>","tool_id":"tool-1","status":"success","output":"Tool executed successfully"}
+{"type":"message","timestamp":"<TIMESTAMP>","role":"assistant","content":"Final answer","delta":true}
+{"type":"result","timestamp":"<TIMESTAMP>","status":"success","stats":{"total_tokens":0,"input_tokens":0,"output_tokens":0,"duration_ms":<DURATION>,"tool_calls":0}}
+"
+`;
+
 exports[`runNonInteractive > should write a single newline between sequential text outputs from the model 1`] = `
 "Use mock tool
 Use mock tool again

packages/cli/src/commands/extensions.test.tsx

@@ -0,0 +1,74 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect, vi } from 'vitest';
+import { extensionsCommand } from './extensions.js';
+
+// Mock subcommands
+vi.mock('./extensions/install.js', () => ({
+  installCommand: { command: 'install' },
+}));
+vi.mock('./extensions/uninstall.js', () => ({
+  uninstallCommand: { command: 'uninstall' },
+}));
+vi.mock('./extensions/list.js', () => ({ listCommand: { command: 'list' } }));
+vi.mock('./extensions/update.js', () => ({
+  updateCommand: { command: 'update' },
+}));
+vi.mock('./extensions/disable.js', () => ({
+  disableCommand: { command: 'disable' },
+}));
+vi.mock('./extensions/enable.js', () => ({
+  enableCommand: { command: 'enable' },
+}));
+vi.mock('./extensions/link.js', () => ({ linkCommand: { command: 'link' } }));
+vi.mock('./extensions/new.js', () => ({ newCommand: { command: 'new' } }));
+vi.mock('./extensions/validate.js', () => ({
+  validateCommand: { command: 'validate' },
+}));
+
+// Mock gemini.js
+vi.mock('../gemini.js', () => ({
+  initializeOutputListenersAndFlush: vi.fn(),
+}));
+
+describe('extensionsCommand', () => {
+  it('should have correct command and aliases', () => {
+    expect(extensionsCommand.command).toBe('extensions <command>');
+    expect(extensionsCommand.aliases).toEqual(['extension']);
+    expect(extensionsCommand.describe).toBe('Manage Gemini CLI extensions.');
+  });
+
+  it('should register all subcommands in builder', () => {
+    const mockYargs = {
+      middleware: vi.fn().mockReturnThis(),
+      command: vi.fn().mockReturnThis(),
+      demandCommand: vi.fn().mockReturnThis(),
+      version: vi.fn().mockReturnThis(),
+    };
+
+    // @ts-expect-error - Mocking yargs
+    extensionsCommand.builder(mockYargs);
+
+    expect(mockYargs.middleware).toHaveBeenCalled();
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'install' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'uninstall' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'list' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'update' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'disable' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'enable' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'link' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'new' });
+    expect(mockYargs.command).toHaveBeenCalledWith({ command: 'validate' });
+    expect(mockYargs.demandCommand).toHaveBeenCalledWith(1, expect.any(String));
+    expect(mockYargs.version).toHaveBeenCalledWith(false);
+  });
+
+  it('should have a handler that does nothing', () => {
+    // @ts-expect-error - Handler doesn't take arguments in this case
+    expect(extensionsCommand.handler()).toBeUndefined();
+  });
+});

packages/cli/src/commands/utils.test.ts

@@ -0,0 +1,41 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { exitCli } from './utils.js';
+import { runExitCleanup } from '../utils/cleanup.js';
+
+vi.mock('../utils/cleanup.js', () => ({
+  runExitCleanup: vi.fn(),
+}));
+
+describe('utils', () => {
+  const originalProcessExit = process.exit;
+
+  beforeEach(() => {
+    // @ts-expect-error - Mocking process.exit
+    process.exit = vi.fn();
+  });
+
+  afterEach(() => {
+    process.exit = originalProcessExit;
+    vi.clearAllMocks();
+  });
+
+  describe('exitCli', () => {
+    it('should call runExitCleanup and process.exit with default exit code 0', async () => {
+      await exitCli();
+      expect(runExitCleanup).toHaveBeenCalled();
+      expect(process.exit).toHaveBeenCalledWith(0);
+    });
+
+    it('should call runExitCleanup and process.exit with specified exit code', async () => {
+      await exitCli(1);
+      expect(runExitCleanup).toHaveBeenCalled();
+      expect(process.exit).toHaveBeenCalledWith(1);
+    });
+  });
+});

packages/cli/src/core/auth.test.ts

@@ -0,0 +1,56 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { performInitialAuth } from './auth.js';
+import { type Config } from '@google/gemini-cli-core';
+
+vi.mock('@google/gemini-cli-core', () => ({
+  AuthType: {
+    OAUTH: 'oauth',
+  },
+  getErrorMessage: (e: unknown) => (e as Error).message,
+}));
+
+const AuthType = {
+  OAUTH: 'oauth',
+} as const;
+
+describe('auth', () => {
+  let mockConfig: Config;
+
+  beforeEach(() => {
+    mockConfig = {
+      refreshAuth: vi.fn(),
+    } as unknown as Config;
+  });
+
+  it('should return null if authType is undefined', async () => {
+    const result = await performInitialAuth(mockConfig, undefined);
+    expect(result).toBeNull();
+    expect(mockConfig.refreshAuth).not.toHaveBeenCalled();
+  });
+
+  it('should return null on successful auth', async () => {
+    const result = await performInitialAuth(
+      mockConfig,
+      AuthType.OAUTH as unknown as Parameters<typeof performInitialAuth>[1],
+    );
+    expect(result).toBeNull();
+    expect(mockConfig.refreshAuth).toHaveBeenCalledWith(AuthType.OAUTH);
+  });
+
+  it('should return error message on failed auth', async () => {
+    const error = new Error('Auth failed');
+    vi.mocked(mockConfig.refreshAuth).mockRejectedValue(error);
+    const result = await performInitialAuth(
+      mockConfig,
+      AuthType.OAUTH as unknown as Parameters<typeof performInitialAuth>[1],
+    );
+    expect(result).toBe('Failed to login. Message: Auth failed');
+    expect(mockConfig.refreshAuth).toHaveBeenCalledWith(AuthType.OAUTH);
+  });
+});

packages/cli/src/core/initializer.test.ts

@@ -0,0 +1,148 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { initializeApp } from './initializer.js';
+import {
+  IdeClient,
+  logIdeConnection,
+  logCliConfiguration,
+  type Config,
+} from '@google/gemini-cli-core';
+import { performInitialAuth } from './auth.js';
+import { validateTheme } from './theme.js';
+import { type LoadedSettings } from '../config/settings.js';
+
+vi.mock('@google/gemini-cli-core', async (importOriginal) => {
+  const actual =
+    await importOriginal<typeof import('@google/gemini-cli-core')>();
+  return {
+    ...actual,
+    IdeClient: {
+      getInstance: vi.fn(),
+    },
+    logIdeConnection: vi.fn(),
+    logCliConfiguration: vi.fn(),
+    StartSessionEvent: vi.fn(),
+    IdeConnectionEvent: vi.fn(),
+  };
+});
+
+vi.mock('./auth.js', () => ({
+  performInitialAuth: vi.fn(),
+}));
+
+vi.mock('./theme.js', () => ({
+  validateTheme: vi.fn(),
+}));
+
+describe('initializer', () => {
+  let mockConfig: {
+    getToolRegistry: ReturnType<typeof vi.fn>;
+    getIdeMode: ReturnType<typeof vi.fn>;
+    getGeminiMdFileCount: ReturnType<typeof vi.fn>;
+  };
+  let mockSettings: LoadedSettings;
+  let mockIdeClient: {
+    connect: ReturnType<typeof vi.fn>;
+  };
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockConfig = {
+      getToolRegistry: vi.fn(),
+      getIdeMode: vi.fn().mockReturnValue(false),
+      getGeminiMdFileCount: vi.fn().mockReturnValue(5),
+    };
+    mockSettings = {
+      merged: {
+        security: {
+          auth: {
+            selectedType: 'oauth',
+          },
+        },
+      },
+    } as unknown as LoadedSettings;
+    mockIdeClient = {
+      connect: vi.fn(),
+    };
+    vi.mocked(IdeClient.getInstance).mockResolvedValue(
+      mockIdeClient as unknown as IdeClient,
+    );
+    vi.mocked(performInitialAuth).mockResolvedValue(null);
+    vi.mocked(validateTheme).mockReturnValue(null);
+  });
+
+  it('should initialize correctly in non-IDE mode', async () => {
+    const result = await initializeApp(
+      mockConfig as unknown as Config,
+      mockSettings,
+    );
+
+    expect(result).toEqual({
+      authError: null,
+      themeError: null,
+      shouldOpenAuthDialog: false,
+      geminiMdFileCount: 5,
+    });
+    expect(performInitialAuth).toHaveBeenCalledWith(mockConfig, 'oauth');
+    expect(validateTheme).toHaveBeenCalledWith(mockSettings);
+    expect(logCliConfiguration).toHaveBeenCalled();
+    expect(IdeClient.getInstance).not.toHaveBeenCalled();
+  });
+
+  it('should initialize correctly in IDE mode', async () => {
+    mockConfig.getIdeMode.mockReturnValue(true);
+    const result = await initializeApp(
+      mockConfig as unknown as Config,
+      mockSettings,
+    );
+
+    expect(result).toEqual({
+      authError: null,
+      themeError: null,
+      shouldOpenAuthDialog: false,
+      geminiMdFileCount: 5,
+    });
+    expect(IdeClient.getInstance).toHaveBeenCalled();
+    expect(mockIdeClient.connect).toHaveBeenCalled();
+    expect(logIdeConnection).toHaveBeenCalledWith(
+      mockConfig as unknown as Config,
+      expect.any(Object),
+    );
+  });
+
+  it('should handle auth error', async () => {
+    vi.mocked(performInitialAuth).mockResolvedValue('Auth failed');
+    const result = await initializeApp(
+      mockConfig as unknown as Config,
+      mockSettings,
+    );
+
+    expect(result.authError).toBe('Auth failed');
+    expect(result.shouldOpenAuthDialog).toBe(true);
+  });
+
+  it('should handle undefined auth type', async () => {
+    mockSettings.merged.security!.auth!.selectedType = undefined;
+    const result = await initializeApp(
+      mockConfig as unknown as Config,
+      mockSettings,
+    );
+
+    expect(result.shouldOpenAuthDialog).toBe(true);
+  });
+
+  it('should handle theme error', async () => {
+    vi.mocked(validateTheme).mockReturnValue('Theme not found');
+    const result = await initializeApp(
+      mockConfig as unknown as Config,
+      mockSettings,
+    );
+
+    expect(result.themeError).toBe('Theme not found');
+  });
+});