Skip to content

Commit 5e218a5

Browse files
authored
Turn off alternate buffer mode by default. (#13623)
1 parent 8c36b10 commit 5e218a5

File tree

7 files changed

+10
-6
lines changed

7 files changed

+10
-6
lines changed

docs/get-started/configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ their corresponding top-level category object in your `settings.json` file.
240240
- **`ui.useAlternateBuffer`** (boolean):
241241
- **Description:** Use an alternate screen buffer for the UI, preserving shell
242242
history.
243-
- **Default:** `true`
243+
- **Default:** `false`
244244
- **Requires restart:** Yes
245245

246246
- **`ui.incrementalRendering`** (boolean):

integration-tests/test-helper.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,9 @@ export class TestRig {
321321
selectedType: 'gemini-api-key',
322322
},
323323
},
324+
ui: {
325+
useAlternateBuffer: true,
326+
},
324327
model: DEFAULT_GEMINI_MODEL,
325328
sandbox:
326329
env['GEMINI_SANDBOX'] !== 'false' ? env['GEMINI_SANDBOX'] : false,

packages/cli/src/config/settingsSchema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ const SETTINGS_SCHEMA = {
516516
label: 'Use Alternate Screen Buffer',
517517
category: 'UI',
518518
requiresRestart: true,
519-
default: true,
519+
default: false,
520520
description:
521521
'Use an alternate screen buffer for the UI, preserving shell history.',
522522
showInDialog: true,

packages/cli/src/gemini.test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,7 @@ describe('startInteractiveUI', () => {
509509
merged: {
510510
ui: {
511511
hideWindowTitle: false,
512+
useAlternateBuffer: true,
512513
},
513514
},
514515
} as LoadedSettings;

packages/cli/src/test-utils/render.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export const renderWithProviders = (
176176
width,
177177
mouseEventsEnabled = false,
178178
config = configProxy as unknown as Config,
179-
useAlternateBuffer,
179+
useAlternateBuffer = true,
180180
uiActions,
181181
}: {
182182
shellFocus?: boolean;

packages/cli/src/ui/hooks/useAlternateBuffer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { useSettings } from '../contexts/SettingsContext.js';
88
import type { LoadedSettings } from '../../config/settings.js';
99

1010
export const isAlternateBufferEnabled = (settings: LoadedSettings): boolean =>
11-
settings.merged.ui?.useAlternateBuffer !== false;
11+
settings.merged.ui?.useAlternateBuffer === true;
1212

1313
export const useAlternateBuffer = (): boolean => {
1414
const settings = useSettings();

schemas/settings.schema.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,8 @@
292292
"useAlternateBuffer": {
293293
"title": "Use Alternate Screen Buffer",
294294
"description": "Use an alternate screen buffer for the UI, preserving shell history.",
295-
"markdownDescription": "Use an alternate screen buffer for the UI, preserving shell history.\n\n- Category: `UI`\n- Requires restart: `yes`\n- Default: `true`",
296-
"default": true,
295+
"markdownDescription": "Use an alternate screen buffer for the UI, preserving shell history.\n\n- Category: `UI`\n- Requires restart: `yes`\n- Default: `false`",
296+
"default": false,
297297
"type": "boolean"
298298
},
299299
"incrementalRendering": {

0 commit comments

Comments
 (0)