Fix(tests): enforce LC_ALL=C for tests to prevent locale-related failures

[AkihiroSuda]

Summary

Fix npm run preflight on non-English host

Details

Added LC_ALL=C to vitest executions

Related Issues

Fixes #14495

How to Validate

Run npm run preflight on non-English host, and confirm that the tests pass.

Pre-Merge Checklist

• (Not applicable) Updated relevant documentation and README (if needed)
• (Not applicable) Added/updated tests (if needed)
• (Not applicable) Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @AkihiroSuda, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the project's test suite by standardizing the locale environment during test execution. By explicitly setting LC_ALL=C, it resolves issues where tests might fail due to differing language or regional settings on developer machines or CI/CD pipelines, thereby improving the reliability and reproducibility of test results across diverse operating environments.

Highlights

• Locale Enforcement for Tests: The LC_ALL=C environment variable is now explicitly enforced for all vitest test executions across various packages.
• Cross-Platform Test Stability: This change aims to prevent locale-related test failures, particularly on non-English host systems, ensuring consistent and reproducible test results across different environments.
• Widespread Application: The LC_ALL=C setting has been applied to relevant test scripts in the root package.json and within the a2a-server, cli, core, and vscode-ide-companion packages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses locale-related test failures by enforcing LC_ALL=C in all vitest commands using cross-env. The changes are consistent across the root package.json and all workspace package.json files. My review focuses on improving the maintainability of the npm scripts by reducing duplication. I've suggested refactoring the test scripts to reuse common commands, which will make them easier to manage and less prone to errors in the future.

[AkihiroSuda]

@jacob314 Could you take a look?

[AkihiroSuda]

@gemini-code-assist Can you suggest human maintainers to request for review and approval?

[gemini-code-assist]

I'm sorry, but as an AI, I am unable to suggest human maintainers for review and approval. My capabilities are limited to providing code review feedback and summaries. If you were trying to invoke a command, please ensure it follows the /gemini <command> or @gemini-code-assist <command> format. You can also type /gemini help to see a list of supported commands.

[AkihiroSuda]

/gemini help

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

[jacob314]

[AkihiroSuda]

Rebased due to the merge conflict

[AkihiroSuda]

@jacob314 Thanks for your approval, could you retrigger the CI?

[AkihiroSuda]

Rebased again

[AkihiroSuda]

@jacob314 Could you merge this?
This PR was already approved two weeks ago

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!

[AkihiroSuda]

we are closing pull requests that haven't seen maintainer activity for 30 days.

This PR was approved and added to the merge queue by @jacob314 just three weeks ago though

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!