-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Open
Labels
area/agentIssues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent QualityIssues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Qualityworkstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreamsπ maintainer onlyβ Do not contribute. Internal roadmap item.β Do not contribute. Internal roadmap item.
Description
Description
Support a new hook decision ask that allows a hook to force a user confirmation prompt, even if a tool is currently allowlisted or the user is running in 'YOLO' mode. This is useful for sensitive operations that require manual oversight regardless of general security policies.
Proposed Behavior
When a BeforeTool hook returns decision: 'ask':
- The
CoreToolSchedulershould interrupt its normal auto-approval logic. - The user should be presented with the standard interactive confirmation prompt for that tool.
- The hook's
systemMessage(if provided) should be displayed to explain why the confirmation is being forced.
Implementation Details
- Move the
BeforeToolhook trigger point fromexecuteToolWithHooksintoCoreToolScheduler._processNextInQueue. - Fire the hook before the
isAutoApprovedcheck. - Update
isAutoApproved(or the logic surrounding it) to respect the hook's decision, prioritizingaskas a requirement for manual confirmation.
Metadata
Metadata
Assignees
Labels
area/agentIssues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent QualityIssues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Qualityworkstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreamsπ maintainer onlyβ Do not contribute. Internal roadmap item.β Do not contribute. Internal roadmap item.
Type
Projects
Status
No status