bug(core): Add workaround + logging for orphaned function calls.

[joshualitt]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the GeminiChat functionality by introducing an automatic history repair mechanism. It addresses a critical issue where the Gemini API would reject requests containing function calls that did not have corresponding function responses in the chat history. By programmatically inserting synthetic responses, the system can now gracefully handle such scenarios, ensuring smoother and more reliable chat interactions. The changes also include logging to monitor these repair operations.

Highlights

• Orphaned Function Call Workaround: Implemented a new mechanism to detect and fix 'orphaned' function calls in the chat history by inserting synthetic function responses. This prevents 400 errors from the Gemini API when function calls lack corresponding responses.
• New History Repair Logic: Introduced a new method, ensureActiveLoopHasFunctionResponses, in the GeminiChat class to proactively ensure all function calls in the conversation history have valid responses before sending the request to the model.
• Telemetry and Logging: Added new telemetry events and logging (logOrphanedFunctionCallFixed) to track instances where orphaned function calls are detected and automatically repaired, providing insights into potential API interaction issues.
• Dedicated Test File for History Repair: Created a new test file, geminiChat_history_repair.test.ts, to specifically cover the new history repair logic, including tests for both function response handling and thought signature management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[joshualitt]

Moved to geminiChat_history_repair.test.ts

[gemini-code-assist]

Code Review

This pull request introduces a robust workaround for handling orphaned function calls in the chat history by injecting synthetic 'unknown' status responses. This prevents API errors and improves chat reliability. The changes include new logic to repair the history, corresponding telemetry for monitoring, and comprehensive unit tests. The refactoring to extract findActiveLoopStartIndex is also a good improvement. My only feedback is a performance suggestion for array manipulation within a loop.

[github-actions]

Size Change: +4.3 kB (+0.02%)

Total Size: 23.2 MB

Filename	Size	Change
./bundle/gemini.js	23.1 MB	+4.3 kB (+0.02%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!