-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Disable esc-esc for rewind #17447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Disable esc-esc for rewind #17447
Conversation
Summary of ChangesHello @Adib234, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request disables the double-ESC key combination's ability to trigger the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables the /rewind functionality that was triggered by pressing Escape twice on an empty prompt. The changes correctly remove the rewind logic from the input prompt handler and update associated tests. However, the proposed comment regarding the StatusDisplay component's UI hint for the double-escape action has been dropped. The suggestion to hide the 'Press Esc again to clear prompt' message when the input buffer is empty contradicts the rule that the Esc-Esc shortcut should consistently clear the input buffer (including when empty or only whitespace), and its UI hints should reflect this behavior. Therefore, the hint should remain visible to maintain consistency with the defined Esc-Esc action.
|
Size Change: -34.4 kB (-0.15%) Total Size: 23.4 MB
ℹ️ View Unchanged
|
|
Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request. To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues. If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding! |
Summary
Don't want rewind functionality to be in a partial state for preview build. Currently
/rewindbrings up unknown command in some nightly builds.Details
Related Issues
How to Validate
Pre-Merge Checklist