Skip to content

Conversation

@Adib234
Copy link
Contributor

@Adib234 Adib234 commented Jan 24, 2026

Summary

Don't want rewind functionality to be in a partial state for preview build. Currently /rewind brings up unknown command in some nightly builds.

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Adib234 Adib234 self-assigned this Jan 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Adib234, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request disables the double-ESC key combination's ability to trigger the /rewind command. The change was implemented to prevent issues with incomplete rewind functionality in preview builds, which could lead to a poor user experience. By removing this partial feature, the user interface for escape key prompts is also simplified, providing a more consistent and predictable interaction.

Highlights

  • Rewind Functionality Disabled: The double-ESC key combination no longer triggers the /rewind command. This feature was disabled due to it being in a partial state and causing 'unknown command' errors in some nightly builds.
  • Simplified Escape Prompt UI: The UI message displayed when pressing Esc once has been simplified. It now consistently shows 'Press Esc again to clear prompt', removing the conditional 'rewind' message.
  • Code Cleanup and Test Updates: Related code for the /rewind functionality, including its submission logic, coreEvents import, and history state usage, has been removed. Corresponding unit tests and UI snapshots have been updated to reflect these changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the /rewind functionality that was triggered by pressing Escape twice on an empty prompt. The changes correctly remove the rewind logic from the input prompt handler and update associated tests. However, the proposed comment regarding the StatusDisplay component's UI hint for the double-escape action has been dropped. The suggestion to hide the 'Press Esc again to clear prompt' message when the input buffer is empty contradicts the rule that the Esc-Esc shortcut should consistently clear the input buffer (including when empty or only whitespace), and its UI hints should reflect this behavior. Therefore, the hint should remain visible to maintain consistency with the defined Esc-Esc action.

@github-actions
Copy link

github-actions bot commented Jan 24, 2026

Size Change: -34.4 kB (-0.15%)

Total Size: 23.4 MB

Filename Size Change
./bundle/gemini.js 23.4 MB -34.4 kB (-0.15%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Jan 24, 2026
@Adib234 Adib234 marked this pull request as ready for review January 26, 2026 17:35
@Adib234 Adib234 requested a review from a team as a code owner January 26, 2026 17:35
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 27, 2026

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!

@gemini-cli gemini-cli bot closed this Jan 27, 2026
@Adib234 Adib234 reopened this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant