refactor common settings logic for skills,agents

[ishaanxgupta]

Related Issues

closes #17348

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @ishaanxgupta, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the internal logic for managing the enabled/disabled states of agents and skills. By introducing a new featureToggleUtils.ts module and a FeatureToggleStrategy pattern, it abstracts the common operations for feature toggling. This change centralizes the core functionality, making the code more modular, reducing duplication in agentSettings.ts and skillSettings.ts, and improving overall maintainability for future feature management.

Highlights

• Code Refactoring for Feature Toggling: Introduced a new utility file, featureToggleUtils.ts, to centralize and abstract the common logic for enabling and disabling various features, such as agents and skills.
• Strategy Pattern Implementation: Implemented a FeatureToggleStrategy interface, allowing for feature-specific logic (e.g., how agents are enabled/disabled versus how skills are) to be defined and passed to generic toggle functions.
• Reduced Code Duplication: Refactored agentSettings.ts and skillSettings.ts to leverage the new generic enableFeature and disableFeature functions, significantly reducing redundant code for managing feature states across different settings scopes.
• Improved Maintainability: The changes enhance the modularity and maintainability of the settings management system by separating generic toggling mechanisms from feature-specific implementation details.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request centralizes the logic for enabling and disabling skills and agents into a new featureToggleUtils.ts utility, significantly reducing code duplication and improving maintainability. However, functions in agentSettings.ts and skillSettings.ts that wrap the new utility produce objects with an incorrect shape, violating their declared types.

[ishaanxgupta]

@sehoon38 please have a look, there are no test files for these 2 files, should I implement them in another PR or should I do them in this itself?

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!