-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitypriority/p1Important and should be addressed in the near term.Important and should be addressed in the near term.windowsWindows OS related fix or improvementWindows OS related fix or improvement
Description
The windows tests are broken by what looks like legitimately bad tests that assume a unix-style directory structure.
⎯⎯⎯⎯⎯⎯⎯ Failed Tests 7 ⎯⎯⎯⎯⎯⎯⎯
FAIL src/ide/ide-client.test.ts > getIdeServerHost > validateWorkspacePath > with special characters and encoding > should return true for a URI-encoded path with spaces
AssertionError: expected false to be true // Object.is equality
- Expected
+ Received
- true
+ false
❯ src/ide/ide-client.test.ts:1141:32
1139| const cwd = '/test/my workspace/sub-dir';
1140| const result = IdeClient.validateWorkspacePath(workspacePath, …
1141| expect(result.isValid).toBe(true);
| ^
1142| });
1143|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/7]⎯
FAIL src/ide/ide-client.test.ts > getIdeServerHost > validateWorkspacePath > with special characters and encoding > should return true for a URI-encoded path with Korean characters
AssertionError: expected false to be true // Object.is equality
- Expected
+ Received
- true
+ false
❯ src/ide/ide-client.test.ts:1148:32
1146| const cwd = '/test/테스트/sub-dir';
1147| const result = IdeClient.validateWorkspacePath(workspacePath, …
1148| expect(result.isValid).toBe(true);
| ^
1149| });
1150|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/7]⎯
FAIL src/ide/ide-client.test.ts > getIdeServerHost > validateWorkspacePath > with special characters and encoding > should return true when one of multi-root paths is a valid URI-encoded path
| ^
516| });
517|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[5/7]⎯
FAIL src/utils/paths.test.ts > resolveToRealPath > 'should handle both file protocol and …'
AssertionError: expected 'file:///path/to/My%20Project' to be '/path/to/My Project' // Object.is equality
Expected: "/path/to/My Project"
Received: "file:///path/to/My%20Project"
❯ src/utils/paths.test.ts:515:38
513| },
514| ])('$description', ({ input, expected }) => {
515| expect(resolveToRealPath(input)).toBe(expected);
| ^
516| });
517|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[6/7]⎯
FAIL src/utils/paths.test.ts > resolveToRealPath > should return decoded path even if fs.realpathSync fails
AssertionError: expected 'file:///path/to/New%20Project' to be '/path/to/New Project' // Object.is equality
Expected: "/path/to/New Project"
Received: "file:///path/to/New%20Project"
❯ src/utils/paths.test.ts:526:38
524| const expected = '/path/to/New Project';
525|
526| expect(resolveToRealPath(input)).toBe(expected);
| ^
527| });
528| });
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[7/7]⎯
Test Files 2 failed | 222 passed (224)
Tests 7 failed | 4186 passed | 31 skipped (4224)
Start at 17:27:14
Duration 40.12s (transform 38.64s, setup 4.49s, collect 485.21s, tests 67.93s, environment 94ms, prepare 49.85s)
JUNIT report written to C:/a/gemini-cli/gemini-cli/packages/core/junit.xml
npm error Lifecycle script `test:ci` failed with error:
npm error code 1
npm error path C:\a\gemini-cli\gemini-cli\packages\core
npm error workspace @google/gemini-cli-core@0.27.0-nightly.20260121.97aac696f
npm error location C:\a\gemini-cli\gemini-cli\packages\core
npm error command failed
npm error command C:\Windows\system32\cmd.exe /d /s /c vitest run
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitypriority/p1Important and should be addressed in the near term.Important and should be addressed in the near term.windowsWindows OS related fix or improvementWindows OS related fix or improvement