Skip to content

Conversation

@DavidAPierce
Copy link
Contributor

Summary

Admin settings were

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@DavidAPierce DavidAPierce requested a review from a team as a code owner January 26, 2026 19:00
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DavidAPierce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's configuration flexibility by introducing administrative override capabilities for key settings. It allows mcpEnabled and extensionsEnabled to be controlled directly via environment variables, providing a mechanism for system administrators to enforce specific behaviors. Additionally, it refines the logic for approvalMode to respect an admin-controlled secure mode setting.

Highlights

  • Admin Overrides for MCP and Extensions: Introduced MCP_ADMIN_ENABLED and EXTENSIONS_ADMIN_ENABLED environment variables to allow administrators to explicitly override the mcpEnabled and extensionsEnabled configuration settings.
  • Approval Mode Logic Update: Modified the approvalMode calculation to incorporate a check for SECURE_MODE_ADMIN_ENABLED, ensuring that YOLO mode is only active if secure mode is not admin-enabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces admin overrides for mcpEnabled, extensionsEnabled, and approvalMode (via SECURE_MODE_ADMIN_ENABLED) through environment variables. The changes are functional, and the suggestion to centralize the parsing logic into a helper function to reduce duplication and improve consistency has been retained as it aligns with general code quality principles and does not contradict any specific rules.

Applying CLI suggested changes.
@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Jan 26, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 27, 2026

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!

@gemini-cli gemini-cli bot closed this Jan 27, 2026
@DavidAPierce DavidAPierce reopened this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant