feat(plan): update cycling order of approval modes

[Adib234]

Summary

As the title suggests, updating from default -> plan -> auto_edit to default -> auto_edit -> plan

Details

Related Issues

Fixes #17615

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @Adib234, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user experience by altering the sequence in which approval modes are cycled through. The change prioritizes the 'Auto-Edit' mode to appear directly after 'Default' when the cycling shortcut is used, aiming to provide a more intuitive flow for users managing their approval settings.

Highlights

• Approval Mode Cycling Order: The order for cycling through approval modes (Default, Plan, Auto-Edit) using Shift+Tab has been updated from Default -> Plan -> Auto-Edit to Default -> Auto-Edit -> Plan.
• User Interface Update: The informative tip displayed to users regarding the approval mode cycling shortcut has been updated to reflect the new order.
• Core Logic Adjustment: The internal logic within the useApprovalModeIndicator hook responsible for determining the next approval mode has been modified to implement the new cycling sequence.
• Unit Test Alignment: Existing unit tests for the useApprovalModeIndicator hook have been updated to validate the correct behavior of the new approval mode cycling order.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the cycling order for approval modes from default -> plan -> auto_edit to default -> auto_edit -> plan. The changes are correctly implemented in the application logic, associated tests, and UI tip text. The code is clear and effectively achieves the desired change. I have no concerns with the implementation.

[github-actions]

Size Change: -5 B (0%)

Total Size: 23.4 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.4 MB	-5 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}