-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Closed
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionality
Description
Description
The current implementation of hooks enablement and disablement in the CLI is inconsistent with the patterns established for skills and agents. This alignment was partially addressed in PR #16822 but it was never merged.
Goals
- Modularize Hook Management: Create
hookSettings.tsandhookUtils.tsinpackages/cli/src/utilsto mirror the structure ofskillSettings.ts/skillUtils.tsandagentSettings.ts/agentUtils.ts. - Dual-Scope Support: Ensure that enabling a hook clears it from the disabled list in both User and Workspace scopes, and disabling a hook targets the appropriate scope (Workspace if available, otherwise User).
- Consistent Feedback: Use a shared or mirrored feedback rendering system (similar to
renderSkillActionFeedback) to provide clear information about which scopes were modified. - Status-Aware Autocompletion: Update
/hooks enableto only suggest currently disabled hooks, and/hooks disableto only suggest currently enabled hooks. - Support 'All' Operations: Ensure
enable-allanddisable-allalso follow these consistent patterns.
Reference
- Closed PR with initial implementation: feat(cli): align hooks enable/disable with skills and improve completion #16822
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionality