diff --git a/packages/core/src/utils/googleQuotaErrors.test.ts b/packages/core/src/utils/googleQuotaErrors.test.ts index 791584e2809..5aaaf16b768 100644 --- a/packages/core/src/utils/googleQuotaErrors.test.ts +++ b/packages/core/src/utils/googleQuotaErrors.test.ts @@ -342,7 +342,7 @@ describe('classifyGoogleError', () => { const result = classifyGoogleError(originalError); expect(result).toBeInstanceOf(RetryableQuotaError); if (result instanceof RetryableQuotaError) { - expect(result.retryDelayMs).toBe(5000); + expect(result.retryDelayMs).toBeUndefined(); } }); @@ -393,7 +393,7 @@ describe('classifyGoogleError', () => { } }); - it('should return RetryableQuotaError with 5s fallback for generic 429 without specific message', () => { + it('should return RetryableQuotaError without delay time for generic 429 without specific message', () => { const generic429 = { status: 429, message: 'Resource exhausted. No specific retry info.', @@ -403,11 +403,11 @@ describe('classifyGoogleError', () => { expect(result).toBeInstanceOf(RetryableQuotaError); if (result instanceof RetryableQuotaError) { - expect(result.retryDelayMs).toBe(5000); + expect(result.retryDelayMs).toBeUndefined(); } }); - it('should return RetryableQuotaError with 5s fallback for 429 with empty details and no regex match', () => { + it('should return RetryableQuotaError without delay time for 429 with empty details and no regex match', () => { const errorWithEmptyDetails = { error: { code: 429, @@ -420,11 +420,11 @@ describe('classifyGoogleError', () => { expect(result).toBeInstanceOf(RetryableQuotaError); if (result instanceof RetryableQuotaError) { - expect(result.retryDelayMs).toBe(5000); + expect(result.retryDelayMs).toBeUndefined(); } }); - it('should return RetryableQuotaError with 5s fallback for 429 with some detail', () => { + it('should return RetryableQuotaError without delay time for 429 with some detail', () => { const errorWithEmptyDetails = { error: { code: 429, @@ -446,7 +446,7 @@ describe('classifyGoogleError', () => { expect(result).toBeInstanceOf(RetryableQuotaError); if (result instanceof RetryableQuotaError) { - expect(result.retryDelayMs).toBe(5000); + expect(result.retryDelayMs).toBeUndefined(); } }); }); diff --git a/packages/core/src/utils/googleQuotaErrors.ts b/packages/core/src/utils/googleQuotaErrors.ts index 3878874c502..4c1234010f4 100644 --- a/packages/core/src/utils/googleQuotaErrors.ts +++ b/packages/core/src/utils/googleQuotaErrors.ts @@ -13,8 +13,6 @@ import type { import { parseGoogleApiError } from './googleErrors.js'; import { getErrorStatus, ModelNotFoundError } from './httpErrors.js'; -const DEFAULT_RETRYABLE_DELAY_SECOND = 5; - /** * A non-retryable error indicating a hard quota limit has been reached (e.g., daily limit). */ @@ -24,11 +22,13 @@ export class TerminalQuotaError extends Error { constructor( message: string, override readonly cause: GoogleApiError, - retryDelayMs?: number, + retryDelaySeconds?: number, ) { super(message); this.name = 'TerminalQuotaError'; - this.retryDelayMs = retryDelayMs ? retryDelayMs * 1000 : undefined; + this.retryDelayMs = retryDelaySeconds + ? retryDelaySeconds * 1000 + : undefined; } } @@ -36,16 +36,18 @@ export class TerminalQuotaError extends Error { * A retryable error indicating a temporary quota issue (e.g., per-minute limit). */ export class RetryableQuotaError extends Error { - retryDelayMs: number; + retryDelayMs?: number; constructor( message: string, override readonly cause: GoogleApiError, - retryDelaySeconds: number, + retryDelaySeconds?: number, ) { super(message); this.name = 'RetryableQuotaError'; - this.retryDelayMs = retryDelaySeconds * 1000; + this.retryDelayMs = retryDelaySeconds + ? retryDelaySeconds * 1000 + : undefined; } } @@ -124,7 +126,6 @@ export function classifyGoogleError(error: unknown): unknown { message: errorMessage, details: [], }, - DEFAULT_RETRYABLE_DELAY_SECOND, ); } @@ -259,7 +260,6 @@ export function classifyGoogleError(error: unknown): unknown { message: errorMessage, details: [], }, - DEFAULT_RETRYABLE_DELAY_SECOND, ); } return error; // Fallback to original error if no specific classification fits. diff --git a/packages/core/src/utils/retry.ts b/packages/core/src/utils/retry.ts index fd91cbd2ff9..c6296f2d95b 100644 --- a/packages/core/src/utils/retry.ts +++ b/packages/core/src/utils/retry.ts @@ -220,6 +220,11 @@ export async function retryWithBackoff( if (classifiedError instanceof RetryableQuotaError || is500) { if (attempt >= maxAttempts) { + const errorMessage = + classifiedError instanceof Error ? classifiedError.message : ''; + debugLogger.warn( + `Attempt ${attempt} failed${errorMessage ? `: ${errorMessage}` : ''}. Max attempts reached`, + ); if (onPersistent429) { try { const fallbackModel = await onPersistent429( @@ -240,8 +245,11 @@ export async function retryWithBackoff( : error; } - if (classifiedError instanceof RetryableQuotaError) { - console.warn( + if ( + classifiedError instanceof RetryableQuotaError && + classifiedError.retryDelayMs !== undefined + ) { + debugLogger.warn( `Attempt ${attempt} failed: ${classifiedError.message}. Retrying after ${classifiedError.retryDelayMs}ms...`, ); await delay(classifiedError.retryDelayMs, signal);