Skip to content

don't show error if we can't detect cpu model #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmaSd wants to merge 3 commits into from
+1 −1
Closed

don't show error if we can't detect cpu model #17457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f0251
don't show error if we can't detect cpu model
sigmaSd Jan 22, 2026
dfdcc51
Merge branch 'main' into patch-1
sigmaSd Jan 24, 2026
e0f15c3
Merge branch 'main' into patch-1
sigmaSd Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ export class ClearcutLogger {
data.push(
{
gemini_cli_key: EventMetadataKey.GEMINI_CLI_CPU_INFO,
value: cpus[0].model,
value: cpus[0]?.model,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While using optional chaining (?.) correctly prevents a crash when os.cpus() returns an empty array, the expression cpus[0]?.model can evaluate to undefined. The value property of the EventValue interface is typed as string, so assigning undefined to it can lead to type errors or unexpected behavior downstream. It's safer to provide a fallback value to ensure type safety, similar to other properties in this file.

Suggested change
value: cpus[0]?.model,
value: cpus[0]?.model ?? '',

},
{
gemini_cli_key: EventMetadataKey.GEMINI_CLI_CPU_CORES,
Expand Down