Fix validation of failure criteria to handle multiple severities and operators (#47)

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->

---------

Signed-off-by: pankhurisaxena28 <[email protected]>

Author: pankhurisaxena28

dist/main/index.js

@@ -111,8 +111,15 @@ function constructKeyValueMapFromString(str?: string): Map<string, string> {
     if (criteria.split(':').length != 2) {
       throw new Error(`string format invalid`);
     }
-    const [key, value] = criteria.split(':');
-    keyValueMap.set(key.trim().toUpperCase(), value.trim().toUpperCase());
+    let [key, value] = criteria.split(':');
+    key = key.trim().toUpperCase();
+    value = value.trim().toUpperCase();
+    if (keyValueMap.has(key) && key == 'OPERATOR') {
+      throw new Error(`multiple operators found`);
+    } else if (keyValueMap.has(key)) {
+      throw new Error(`multiple severities of type ${key} found`);
+    }
+    keyValueMap.set(key, value);
   });
   return keyValueMap;
 }
@@ -125,19 +132,13 @@ function validateAndExtractFailureCriteriaFromMap(
 
   keyValueMap.forEach((value, key) => {
     if (isValidOperatorKey(key)) {
-      if (operator) {
-        throw new Error(`multiple operators found`);
-      }
       operator = extractOperatorValue(value);
       return;
     }
     const severity: Severity = extractSeverityKey(
       key,
       /** errMsg= */ `invalid key: ${key}, value: ${value} pair found`,
     );
-    if (violationsThresholdBySeverity.has(severity)) {
-      throw new Error(`multiple severities of type ${key} found`);
-    }
     if (isNaN(+value)) {
       throw new Error(`invalid severity count`);
     }

src/utils.ts

@@ -121,6 +121,11 @@ test(
         input: 'Low: 1, Operator: OR, Operator: OR',
         error: 'failure_criteria validation failed : multiple operators found',
       },
+      {
+        name: 'multiple operators',
+        input: 'Low: 1, Operator: AND, Operator: OR',
+        error: 'failure_criteria validation failed : multiple operators found',
+      },
       {
         name: 'no operator',
         input: 'Low: 1',