Skip to content

Commit 10f7d5a

Browse files
authored
Update deps to Node 20 (#334)
1 parent 89a9877 commit 10f7d5a

File tree

10 files changed

+333
-313
lines changed

10 files changed

+333
-313
lines changed

.github/workflows/cleanup.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: 'ubuntu-latest'
1515

1616
steps:
17-
- uses: 'actions/checkout@v3'
17+
- uses: 'actions/checkout@v4'
1818

1919
- uses: 'google-github-actions/auth@main'
2020
with:

.github/workflows/integration.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ jobs:
2222
runs-on: 'ubuntu-latest'
2323

2424
steps:
25-
- uses: 'actions/checkout@v3'
25+
- uses: 'actions/checkout@v4'
2626

27-
- uses: 'actions/setup-node@v3'
27+
- uses: 'actions/setup-node@v4'
2828
with:
29-
node-version: '16.x'
29+
node-version: '20.x'
3030

3131
- name: 'npm build'
3232
run: 'npm ci && npm run build'

.github/workflows/unit.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ jobs:
2525
runs-on: '${{ matrix.os }}'
2626

2727
steps:
28-
- uses: 'actions/checkout@v3'
28+
- uses: 'actions/checkout@v4'
2929

30-
- uses: 'actions/setup-node@v3'
30+
- uses: 'actions/setup-node@v4'
3131
with:
32-
node-version: '16.x'
32+
node-version: '20.x'
3333

3434
- name: 'npm build'
3535
run: 'npm ci && npm run build'

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,5 +116,5 @@ branding:
116116
color: 'blue'
117117

118118
runs:
119-
using: 'node16'
119+
using: 'node20'
120120
main: 'dist/index.js'

dist/index.js

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example-app/app.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
runtime: nodejs16
15+
runtime: nodejs20

package-lock.json

Lines changed: 298 additions & 282 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,28 +23,28 @@
2323
"author": "Google LLC",
2424
"license": "Apache-2.0",
2525
"dependencies": {
26-
"@actions/core": "^1.10.0",
26+
"@actions/core": "^1.10.1",
2727
"@actions/exec": "^1.1.1",
28-
"@google-github-actions/actions-utils": "^0.4.8",
29-
"@google-github-actions/setup-cloud-sdk": "^1.1.2",
30-
"yaml": "^2.3.1"
28+
"@google-github-actions/actions-utils": "^0.4.9",
29+
"@google-github-actions/setup-cloud-sdk": "^1.1.3",
30+
"yaml": "^2.3.4"
3131
},
3232
"devDependencies": {
3333
"@types/chai": "^4.3.x",
34-
"@types/mocha": "^10.0.1",
35-
"@types/node": "^20.4.1",
36-
"@types/sinon": "^10.0.15",
37-
"@typescript-eslint/eslint-plugin": "^6.0.0",
38-
"@typescript-eslint/parser": "^6.0.0",
39-
"@vercel/ncc": "^0.36.1",
34+
"@types/mocha": "^10.0.4",
35+
"@types/node": "^20.9.0",
36+
"@types/sinon": "^17.0.1",
37+
"@typescript-eslint/eslint-plugin": "^6.10.0",
38+
"@typescript-eslint/parser": "^6.10.0",
39+
"@vercel/ncc": "^0.38.1",
4040
"chai": "^4.3.x",
41-
"eslint": "^8.44.0",
42-
"eslint-config-prettier": "^8.8.0",
41+
"eslint": "^8.53.0",
42+
"eslint-config-prettier": "^9.0.0",
4343
"eslint-plugin-prettier": "^5.0.x",
4444
"mocha": "^10.2.0",
45-
"prettier": "^3.0.0",
46-
"sinon": "^15.2.0",
45+
"prettier": "^3.0.3",
46+
"sinon": "^17.0.1",
4747
"ts-node": "^10.9.1",
48-
"typescript": "^5.1.6"
48+
"typescript": "^5.2.2"
4949
}
5050
}

tests/main.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ describe('#run', function () {
192192
expect(
193193
setOutput.calledWith('name', 'apps/my-project/services/default/versions/20221215t102539'),
194194
).to.be.ok;
195-
expect(setOutput.calledWith('runtime', 'nodejs16')).to.be.ok;
195+
expect(setOutput.calledWith('runtime', 'nodejs20')).to.be.ok;
196196
expect(setOutput.calledWith('service_account_email', '[email protected]'))
197197
.to.be.ok;
198198
expect(setOutput.calledWith('serving_status', 'SERVING')).to.be.ok;
@@ -505,7 +505,7 @@ const testDescribeResponse = `
505505
"instanceClass": "F1",
506506
"name": "apps/my-project/services/default/versions/20221215t102539",
507507
"network": {},
508-
"runtime": "nodejs16",
508+
"runtime": "nodejs20",
509509
"runtimeChannel": "default",
510510
"serviceAccount": "[email protected]",
511511
"servingStatus": "SERVING",

tests/output-parser.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('#parseDeployResponse', () => {
9494
"instanceClass": "F1",
9595
"name": "apps/my-project/services/default/versions/20221117t121206",
9696
"network": {},
97-
"runtime": "nodejs16",
97+
"runtime": "nodejs20",
9898
"runtimeChannel": "default",
9999
"serviceAccount": "[email protected]",
100100
"servingStatus": "SERVING",
@@ -153,7 +153,7 @@ describe('#parseDeployResponse', () => {
153153
"instanceClass": "F1",
154154
"name": "apps/my-project/services/default/versions/123",
155155
"network": {},
156-
"runtime": "nodejs16",
156+
"runtime": "nodejs20",
157157
"runtimeChannel": "default",
158158
"serviceAccount": "[email protected]",
159159
"servingStatus": "SERVING",
@@ -259,7 +259,7 @@ describe('#parseDescribeResponse', () => {
259259
"instanceClass": "F1",
260260
"name": "apps/my-project/services/default/versions/20221215t102539",
261261
"network": {},
262-
"runtime": "nodejs16",
262+
"runtime": "nodejs20",
263263
"runtimeChannel": "default",
264264
"serviceAccount": "[email protected]",
265265
"servingStatus": "SERVING",
@@ -269,7 +269,7 @@ describe('#parseDescribeResponse', () => {
269269
`,
270270
expected: {
271271
name: 'apps/my-project/services/default/versions/20221215t102539',
272-
runtime: 'nodejs16',
272+
runtime: 'nodejs20',
273273
serviceAccountEmail: '[email protected]',
274274
servingStatus: 'SERVING',
275275
versionID: '20221215t102539',

0 commit comments

Comments
 (0)