Update linters (#384)

Author: sethvargo

.github/workflows/cleanup.yml

@@ -23,15 +23,17 @@ jobs:
 
       - uses: 'google-github-actions/setup-gcloud@v2' # ratchet:exclude
 
-      - name: Delete services
+      - name: 'Delete services'
+        env:
+          PROJECT_ID: '${{ vars.PROJECT_ID }}'
         run: |-
-          gcloud config set core/project "${{ vars.PROJECT_ID }}"
+          gcloud config set "core/project" "${PROJECT_ID}"
 
           # List and delete all versions that were deployed 30 minutes ago or
           # earlier. The date math here is a little weird, but we're looking for
           # deployments "earlier than" 30 minutes ago, so it's less than since
           # time increases.
-          (IFS=$'\n'; for NAME in $(gcloud app versions list --format="value(id)" --filter="service != "default" AND version.createTime < '-pt30m'"); do
+          (IFS=$'\n'; for NAME in $(gcloud app versions list --format='value(id)' --filter='service != "default" AND version.createTime < "-pt30m"'); do
             echo "Deleting ${NAME}..."
-            gcloud app versions delete ${NAME} --quiet
+            gcloud app versions delete "${NAME}" --quiet
           done)

.github/workflows/integration.yml

@@ -17,7 +17,8 @@ concurrency:
 
 jobs:
   integration:
-    if: ${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
+    if: |-
+      ${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
     permissions:
       contents: 'read'
       id-token: 'write'
@@ -28,7 +29,7 @@ jobs:
 
       - uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
         with:
-          node-version: '20.x'
+          node-version-file: 'package.json'
 
       - name: 'npm build'
         run: 'npm ci && npm run build'
@@ -46,6 +47,7 @@ jobs:
         id: 'deploy'
         uses: './'
         with:
+          project_id: '${{ vars.PROJECT_ID }}'
           working_directory: '${{ github.workspace }}/example-app'
           build_env_vars: |-
             FOO=bar

.github/workflows/unit.yml

@@ -31,16 +31,10 @@ jobs:
 
       - uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
         with:
-          node-version: '20.x'
+          node-version-file: 'package.json'
 
       - name: 'npm build'
         run: 'npm ci && npm run build'
 
-      - name: 'npm lint'
-        # There's no need to run the linter for each operating system, since it
-        # will find the same thing 3x and clog up the PR review.
-        if: ${{ matrix.os == 'ubuntu-latest' }}
-        run: 'npm run lint'
-
       - name: 'npm test'
         run: 'npm run test'

action.yml

@@ -54,7 +54,7 @@ inputs:
     description: |-
       Promote the deployed version to receive all traffic.
     required: false
-    default: "true"
+    default: 'true'
 
   flags:
     description: |-

bin/runTests.sh

@@ -16,4 +16,6 @@ set -eEuo pipefail
 FILES="$(node -e "process.stdout.write(require('node:fs').readdirSync('./', { recursive: true }).filter((e) => {return e.endsWith('.test.ts') && !e.startsWith('node_modules');}).sort().join(' '));")"
 
 set -x
+
+# shellcheck disable=SC2086
 exec node --require ts-node/register --test-reporter spec --test ${FILES}

example-app/app.yaml

@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-runtime: nodejs20
+runtime: 'nodejs20'

package.json

@@ -9,6 +9,10 @@
     "format": "eslint . --fix",
     "test": "bash ./bin/runTests.sh"
   },
+  "engines": {
+    "node": "20.x",
+    "npm": "10.x"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/google-github-actions/deploy-appengine"