feat: remove beta installation and use from GA components (#377) (#379)

Fixes GH-376

Author: sethvargo

dist/main/index.js

@@ -60,7 +60,7 @@ export async function run(): Promise<void> {
     const credentials = core.getInput('credentials'); // Service account key
     let projectId = core.getInput('project_id');
     let gcloudVersion = core.getInput('gcloud_version');
-    let gcloudComponent = presence(core.getInput('gcloud_component')); // Cloud SDK component version
+    const gcloudComponent = presence(core.getInput('gcloud_component')); // Cloud SDK component version
     // Flags
     const envVars = parseKVString(core.getInput('env_vars')); // String of env vars KEY=VALUE,...
     const secrets = parseKVString(core.getInput('secrets')); // String of secrets KEY=VALUE,...
@@ -116,7 +116,6 @@ export async function run(): Promise<void> {
         '--region',
         region,
       ];
-      gcloudComponent = gcloudComponent ?? 'beta';
       if (revTraffic) cmd.push('--to-revisions', revTraffic);
       if (tagTraffic) cmd.push('--to-tags', tagTraffic);
     } else if (source) {
@@ -133,7 +132,6 @@ export async function run(): Promise<void> {
         '--source',
         source,
       ];
-      gcloudComponent = gcloudComponent ?? 'beta';
       if (timeout) cmd.push('--timeout', timeout);
     } else if (metadata) {
       // Deploy service from metadata
@@ -143,7 +141,6 @@ export async function run(): Promise<void> {
         );
       }
       cmd = ['run', 'services', 'replace', metadata, '--platform', 'managed', '--region', region];
-      gcloudComponent = gcloudComponent ?? 'beta';
     } else {
       // Deploy service with image specified
       cmd = [
@@ -166,11 +163,9 @@ export async function run(): Promise<void> {
       }
       if (secrets && Object.keys(secrets).length > 0) {
         cmd.push('--update-secrets', kvToString(secrets));
-        gcloudComponent = gcloudComponent ?? 'beta';
       }
       if (tag) {
         cmd.push('--tag', tag);
-        gcloudComponent = gcloudComponent ?? 'beta';
       }
       if (suffix) cmd.push('--revision-suffix', suffix);
       if (noTraffic) cmd.push('--no-traffic');

src/main.ts

@@ -113,18 +113,24 @@ describe('#deploy-cloudrun', function () {
       await run();
       expect(this.stubs.setFailed.callCount).to.be.at.least(1);
     });
-    it('installs beta components with source', async function () {
+    it('sets source if given', async function () {
       this.stubs.getInput.withArgs('source').returns('example-app');
       this.stubs.getInput.withArgs('image').returns('');
       await run();
-      expect(this.stubs.installComponent.withArgs('beta').callCount).to.eq(1);
+      const call = this.stubs.getExecOutput.getCall(0);
+      expect(call).to.be;
+      const args = call.args[1];
+      expect(args).to.include.members(['--source', 'example-app']);
     });
-    it('installs beta components with metadata', async function () {
+    it('sets metadata if given', async function () {
       this.stubs.getInput.withArgs('metadata').returns('yaml');
       this.stubs.getInput.withArgs('image').returns('');
       this.stubs.getInput.withArgs('service').returns('');
       await run();
-      expect(this.stubs.installComponent.withArgs('beta').callCount).to.eq(1);
+      const call = this.stubs.getExecOutput.getCall(0);
+      expect(call).to.be;
+      const args = call.args[1];
+      expect(args).to.include.members(['services', 'replace', 'yaml']);
     });
     it('sets timeout if given', async function () {
       this.stubs.getInput.withArgs('timeout').returns('55m12s');
@@ -134,16 +140,22 @@ describe('#deploy-cloudrun', function () {
       const args = call.args[1];
       expect(args).to.include.members(['--timeout', '55m12s']);
     });
-    it('installs beta components with tag', async function () {
+    it('sets tag if given', async function () {
       this.stubs.getInput.withArgs('tag').returns('test');
       await run();
-      expect(this.stubs.installComponent.withArgs('beta').callCount).to.eq(1);
+      const call = this.stubs.getExecOutput.getCall(0);
+      expect(call).to.be;
+      const args = call.args[1];
+      expect(args).to.include.members(['--tag', 'test']);
     });
-    it('installs beta components with tag traffic', async function () {
+    it('sets tag traffic if given', async function () {
       this.stubs.getInput.withArgs('tag').returns('test');
       this.stubs.getInput.withArgs('name').returns('service-name');
       await run();
-      expect(this.stubs.installComponent.withArgs('beta').callCount).to.eq(1);
+      const call = this.stubs.getExecOutput.getCall(0);
+      expect(call).to.be;
+      const args = call.args[1];
+      expect(args).to.include.members(['--tag', 'test']);
     });
     it('fails if tag traffic and revision traffic are provided', async function () {
       this.stubs.getInput.withArgs('revision_traffic').returns('TEST=100');