Skip to content

Commit 69ea22f

Browse files
fix: pass all tests that be written in deploy-cloudrun.test.ts. (#345)
Because `describe.only` was written in the `deploy-cloudrun.test.ts` file, all tests in that file did not pass. Therefore, we changed `describe.only` to `describe`. Also, the `expect` message was wrong when the `gcloud_component` argument had an incorrect value, so we fixed this.
1 parent ed4a124 commit 69ea22f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

tests/unit/deploy-cloudrun.test.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,8 @@ describe('#deploy-cloudrun', function () {
170170
it('throws error with invalid gcloud component flag', async function () {
171171
this.stubs.getInput.withArgs('gcloud_component').returns('wrong_value');
172172
await run();
173-
expect(
174-
this.stubs.setFailed.withArgs(`invalid input received for gcloud_component: wrong_value`)
175-
.callCount,
176-
).to.be.at.least(1);
173+
const msg = `google-github-actions/deploy-cloudrun failed with: invalid input received for gcloud_component: wrong_value`;
174+
expect(this.stubs.setFailed.withArgs(`${msg}`).callCount).to.be.at.least(1);
177175
});
178176
it('installs alpha component with alpha flag', async function () {
179177
this.stubs.getInput.withArgs('gcloud_component').returns('alpha');
@@ -187,7 +185,7 @@ describe('#deploy-cloudrun', function () {
187185
});
188186
});
189187

190-
describe.only('#kvToString', () => {
188+
describe('#kvToString', () => {
191189
const cases = [
192190
{
193191
name: `empty`,

0 commit comments

Comments
 (0)