Fix documentation + Added alternate way to auth for docker (#5)

* fix readme

Signed-off-by: Mateusz Piórowski <[email protected]>

* fix

Signed-off-by: Mateusz Piórowski <[email protected]>

* added missing repository name

Signed-off-by: Mateusz Piórowski <[email protected]>

Signed-off-by: Mateusz Piórowski <[email protected]>

Author: mpiorowski

workflows/deploy-cloudrun/cloudrun-docker.yml

@@ -52,6 +52,7 @@ on:
 env:
   PROJECT_ID: YOUR_PROJECT_ID # TODO: update Google Cloud project id
   GAR_LOCATION: YOUR_GAR_LOCATION # TODO: update Artifact Registry location
+  REPOSITORY: YOUR_REPOSITORY_NAME # TODO: update Artifact Registry repository name
   SERVICE: YOUR_SERVICE_NAME # TODO: update Cloud Run service name
   REGION: YOUR_SERVICE_REGION # TODO: update Cloud Run service region
 
@@ -80,7 +81,7 @@ jobs:
       #   id: auth
       #   uses: 'google-github-actions/auth@v0'
       #   with:
-      #     credentials_json: '${{ secrets.GCP_CREDENTIALS }}''
+      #     credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
 
       # BEGIN - Docker auth and build (NOTE: If you already have a container image, these Docker steps can be omitted)
 
@@ -92,11 +93,20 @@ jobs:
           username: 'oauth2accesstoken'
           password: '${{ steps.auth.outputs.access_token }}'
           registry: '${{ env.GAR_LOCATION }}-docker.pkg.dev'
+          
+      # NOTE: Alternative option - authentication via credentials json
+      # - name: Docker Auth
+      # id: docker-auth
+      # uses: 'docker/login-action@v1'
+      # with:
+      #   registry: ${{ env.GAR_LOCATION }}-docker.pkg.dev
+      #   username: _json_key
+      #   password: ${{ secrets.GCP_CREDENTIALS }}
 
       - name: Build and Push Container
         run: |-
-          docker build -t "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}" ./
-          docker push "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}"
+          docker build -t "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}" ./
+          docker push "${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}"
 
       # END - Docker auth and build
 
@@ -107,7 +117,11 @@ jobs:
           service: ${{ env.SERVICE }}
           region: ${{ env.REGION }}
           # NOTE: If using a pre-built image, update the image name here
-          image: ${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}
+          image: ${{ env.GAR_LOCATION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}
+          # NOTE: You can also set env variables here:
+          #  env_vars: |
+          #  NODE_ENV=production
+          #  TOKEN_EXPIRE=6400
 
       # If required, use the Cloud Run url output in later steps
       - name: Show Output