Skip to content

Commit 11125bf

Browse files
davidyunsethvargo
andauthored
Fix broken credentials_json example (#6)
<!-- Thank you for proposing a pull request! Please note that SOME TESTS WILL LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from forks. Someone from the team will review your Pull Request and respond. Please describe your change and any implementation details below. --> When authenticating with `credentials_json`, if you do not specify the `token_format` the build breaks. I added the fix to the example. ![image](https://user-images.githubusercontent.com/1341777/190628523-c724f492-45e3-4165-a619-8ce9c5c631b8.png) --------- Signed-off-by: Seth Vargo <[email protected]> Co-authored-by: Seth Vargo <[email protected]>
1 parent 4cd07d6 commit 11125bf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

workflows/deploy-cloudrun/cloudrun-docker.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
# uses: 'google-github-actions/auth@v0'
8686
# with:
8787
# credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
88+
# token_format: 'access_token'
8889

8990
# BEGIN - Docker auth and build (NOTE: If you already have a container image, these Docker steps can be omitted)
9091

0 commit comments

Comments
 (0)