Skip to content

Commit ffd2b4a

Browse files
authored
Bump to Node 24 (#324)
1 parent 2b5f97c commit ffd2b4a

File tree

7 files changed

+24
-40
lines changed

7 files changed

+24
-40
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
paths:
2+
'**/*.yml':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'
6+
27
'.github/workflows/integration.yml':
38
ignore:
49
- 'property ".+" is not defined in object type'

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: 'npm build'
3838
run: 'npm ci && npm run build'
3939

40-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
40+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
4141
with:
4242
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
4343
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ jobs:
3838

3939
steps:
4040
- id: 'auth'
41-
uses: 'google-github-actions/auth@v2'
41+
uses: 'google-github-actions/auth@v3'
4242
with:
4343
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
4444
service_account: '[email protected]'
4545

4646
- id: 'secrets'
47-
uses: 'google-github-actions/get-secretmanager-secrets@v2'
47+
uses: 'google-github-actions/get-secretmanager-secrets@v3'
4848
with:
4949
secrets: |-
5050
token:my-project/docker-registry-token
@@ -124,7 +124,7 @@ jobs:
124124
job_id:
125125
steps:
126126
- id: 'secrets'
127-
uses: 'google-github-actions/get-secretmanager-secrets@v2'
127+
uses: 'google-github-actions/get-secretmanager-secrets@v3'
128128
with:
129129
secrets: |-
130130
token:my-project/docker-registry-token
@@ -162,13 +162,13 @@ jobs:
162162
- uses: 'actions/checkout@v4'
163163
164164
- id: 'auth'
165-
uses: 'google-github-actions/auth@v2'
165+
uses: 'google-github-actions/auth@v3'
166166
with:
167167
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
168168
service_account: '[email protected]'
169169
170170
- id: 'secrets'
171-
uses: 'google-github-actions/get-secretmanager-secrets@v2'
171+
uses: 'google-github-actions/get-secretmanager-secrets@v3'
172172
```
173173

174174
### Via Application Default Credentials
@@ -183,7 +183,7 @@ jobs:
183183
job_id:
184184
steps:
185185
- id: 'secrets'
186-
uses: 'google-github-actions/get-secretmanager-secrets@v2'
186+
uses: 'google-github-actions/get-secretmanager-secrets@v3'
187187
```
188188

189189
The action will automatically detect and use the Application Default

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ outputs:
9696
job_id:
9797
steps:
9898
- id: 'secrets'
99-
uses: 'google-github-actions/get-secretmanager-secrets@v2'
99+
uses: 'google-github-actions/get-secretmanager-secrets@v3'
100100
with:
101101
secrets: |-
102102
token:my-project/docker-registry-token
@@ -113,5 +113,5 @@ branding:
113113
color: 'blue'
114114

115115
runs:
116-
using: 'node20'
116+
using: 'node24'
117117
main: 'dist/main/index.js'

bin/runTests.sh

Lines changed: 0 additions & 21 deletions
This file was deleted.

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
"docs": "./node_modules/.bin/actions-gen-readme",
99
"lint": "eslint .",
1010
"format": "eslint . --fix",
11-
"test": "bash ./bin/runTests.sh"
11+
"test": "node --require ts-node/register --test-reporter spec --test tests/**/*.test.ts"
1212
},
1313
"engines": {
14-
"node": ">= 20.x",
14+
"node": ">= 24.x",
1515
"npm": ">= 11.x"
1616
},
1717
"repository": {
@@ -29,7 +29,7 @@
2929
"dependencies": {
3030
"@actions/core": "^1.11.1",
3131
"@actions/http-client": "^2.2.3",
32-
"@google-github-actions/actions-utils": "^0.8.10",
32+
"@google-github-actions/actions-utils": "^1.0.1",
3333
"google-auth-library": "^10.1.0"
3434
},
3535
"devDependencies": {

0 commit comments

Comments
 (0)