Skip to content

Commit a4fcccd

Browse files
committed
Bump to node24
1 parent e427ad8 commit a4fcccd

File tree

6 files changed

+28
-36
lines changed

6 files changed

+28
-36
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
paths:
2+
'*':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'

.github/workflows/integration.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,28 +46,24 @@ jobs:
4646
uses: './'
4747
with:
4848
skip_install: true
49-
skip_tool_cache: true
5049

5150
# Constraint installation
5251
- name: 'Install constraint'
5352
uses: './'
5453
with:
5554
version: '>= 1.0.0'
56-
skip_tool_cache: true
5755

5856
# Default installation
5957
- name: 'Install version'
6058
uses: './'
6159
with:
6260
version: '374.0.0'
63-
skip_tool_cache: true
6461

6562
# Latest installation
6663
- name: 'Install latest'
6764
uses: './'
6865
with:
6966
version: 'latest'
70-
skip_tool_cache: true
7167

7268
# By default, there is no configuration
7369
- name: 'Check defaults'
@@ -81,7 +77,6 @@ jobs:
8177
uses: './'
8278
with:
8379
install_components: 'cloud-run-proxy'
84-
skip_tool_cache: true
8580

8681
- name: 'Check components'
8782
run: 'npm run integration'
@@ -93,7 +88,6 @@ jobs:
9388
uses: './'
9489
with:
9590
project_id: '${{ vars.PROJECT_ID }}'
96-
skip_tool_cache: true
9791

9892
- name: 'Check project ID'
9993
run: 'npm run integration'
@@ -109,8 +103,6 @@ jobs:
109103

110104
- name: 'Setup gcloud with WIF'
111105
uses: './'
112-
with:
113-
skip_tool_cache: true
114106

115107
- name: 'Check WIF authentication'
116108
run: 'npm run integration'
@@ -126,8 +118,6 @@ jobs:
126118

127119
- name: 'Setup gcloud with SAKE'
128120
uses: './'
129-
with:
130-
skip_tool_cache: true
131121

132122
- name: 'Check SAKE authentication'
133123
run: 'npm run integration'

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
service_account: '[email protected]'
4747

4848
- name: 'Set up Cloud SDK'
49-
uses: 'google-github-actions/setup-gcloud@v2'
49+
uses: 'google-github-actions/setup-gcloud@v3'
5050
with:
5151
version: '>= 363.0.0'
5252

@@ -63,7 +63,7 @@ jobs:
6363
value is `"latest"`, which will always download and install the latest
6464
available Cloud SDK version.
6565

66-
- uses: 'google-github-actions/setup-gcloud@v2'
66+
- uses: 'google-github-actions/setup-gcloud@v3'
6767
with:
6868
version: '>= 416.0.0'
6969

@@ -76,7 +76,7 @@ jobs:
7676
or newer. If you need support for Workload Identity Federation, specify
7777
your version constraint as such:
7878

79-
- uses: 'google-github-actions/setup-gcloud@v2'
79+
- uses: 'google-github-actions/setup-gcloud@v3'
8080
with:
8181
version: '>= 363.0.0'
8282

@@ -152,7 +152,7 @@ jobs:
152152
service_account: '[email protected]'
153153
154154
- name: 'Set up Cloud SDK'
155-
uses: 'google-github-actions/setup-gcloud@v2'
155+
uses: 'google-github-actions/setup-gcloud@v3'
156156
157157
- name: 'Use gcloud CLI'
158158
run: 'gcloud info'
@@ -170,7 +170,7 @@ jobs:
170170
credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
171171
172172
- name: 'Set up Cloud SDK'
173-
uses: 'google-github-actions/setup-gcloud@v2'
173+
uses: 'google-github-actions/setup-gcloud@v3'
174174
175175
- name: 'Use gcloud CLI'
176176
run: 'gcloud info'
@@ -187,7 +187,7 @@ jobs:
187187
job_id:
188188
steps:
189189
- name: 'Set up Cloud SDK'
190-
uses: 'google-github-actions/setup-gcloud@v2'
190+
uses: 'google-github-actions/setup-gcloud@v3'
191191
192192
- name: 'Use gcloud CLI'
193193
run: 'gcloud info'
@@ -213,7 +213,7 @@ jobs:
213213
service_account: '[email protected]'
214214
215215
- name: 'Set up Cloud SDK'
216-
uses: 'google-github-actions/setup-gcloud@v2'
216+
uses: 'google-github-actions/setup-gcloud@v3'
217217
218218
- name: 'Use gcloud CLI'
219219
run: 'gcloud auth list --filter=status:ACTIVE --format="value(account)"'
@@ -225,7 +225,7 @@ jobs:
225225
credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
226226
227227
- name: 'Set up Cloud SDK'
228-
uses: 'google-github-actions/setup-gcloud@v2'
228+
uses: 'google-github-actions/setup-gcloud@v3'
229229
230230
- name: 'Use gcloud CLI'
231231
run: 'gcloud auth list --filter=status:ACTIVE --format="value(account)"'
@@ -238,15 +238,15 @@ jobs:
238238
We recommend pinning to the latest available major version:
239239

240240
```yaml
241-
- uses: 'google-github-actions/setup-gcloud@v2'
241+
- uses: 'google-github-actions/setup-gcloud@v3'
242242
```
243243

244244
While this action attempts to follow semantic versioning, but we're ultimately
245245
human and sometimes make mistakes. To prevent accidental breaking changes, you
246246
can also pin to a specific version:
247247

248248
```yaml
249-
- uses: 'google-github-actions/setup-gcloud@v2.0.0'
249+
- uses: 'google-github-actions/setup-gcloud@v3.0.0'
250250
```
251251

252252
However, you will not get automatic security updates or new features without

action.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ inputs:
2626
value is `"latest"`, which will always download and install the latest
2727
available Cloud SDK version.
2828
29-
- uses: 'google-github-actions/setup-gcloud@v2'
29+
- uses: 'google-github-actions/setup-gcloud@v3'
3030
with:
3131
version: '>= 416.0.0'
3232
@@ -39,7 +39,7 @@ inputs:
3939
or newer. If you need support for Workload Identity Federation, specify
4040
your version constraint as such:
4141
42-
- uses: 'google-github-actions/setup-gcloud@v2'
42+
- uses: 'google-github-actions/setup-gcloud@v3'
4343
with:
4444
version: '>= 363.0.0'
4545
@@ -77,15 +77,12 @@ inputs:
7777
default: false
7878
required: false
7979

80-
skip_tool_cache:
80+
cache:
8181
description: |-
82-
Skip transferring the downloaded artifacts into the runner's tool cache.
83-
On GitHub-managed runners, this makes no difference since they are
84-
ephemeral. On self-hosted runners, this controls whether the downloads are
85-
cached stored on the disk.
86-
87-
For backwards-compatibility, this is is "false" by default. Setting the
88-
value to "true" can significantly speed up installation times.
82+
Transfer the downloaded artifacts into the runner's tool cache. On
83+
GitHub-managed runners, this have very little impact since runneres are
84+
ephemeral. On self-hosted runners, this could improve future runs by
85+
skipping future gcloud installations.
8986
default: false
9087
required: false
9188

@@ -99,5 +96,5 @@ branding:
9996
color: 'blue'
10097

10198
runs:
102-
using: 'node20'
99+
using: 'node24'
103100
main: 'dist/index.js'

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
"test": "node --require ts-node/register --test-reporter spec --test tests/setup-gcloud.test.ts"
1313
},
1414
"engines": {
15-
"node": ">= 20.x",
16-
"npm": ">= 10.x"
15+
"node": ">= 24.x",
16+
"npm": ">= 11.x"
1717
},
1818
"repository": {
1919
"type": "git",

src/main.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ export async function run(): Promise<void> {
4848

4949
// Warn if pinned to HEAD
5050
if (isPinnedToHead()) {
51-
core.warning(pinnedToHeadWarning('v2'));
51+
core.warning(pinnedToHeadWarning('v3'));
5252
}
5353

5454
try {
5555
const skipInstall = parseBoolean(core.getInput('skip_install'));
5656
let version = presence(core.getInput('version'));
5757
const components = core.getInput('install_components');
5858
const projectId = core.getInput('project_id');
59-
const skipToolCache = parseBoolean(core.getInput('skip_tool_cache'));
59+
const cache = parseBoolean(core.getInput('cache'));
6060

6161
if (skipInstall) {
6262
core.info(`Skipping installation ("skip_install" was true)`);
@@ -91,7 +91,7 @@ export async function run(): Promise<void> {
9191
core.addPath(path.join(toolPath, 'bin'));
9292
} else {
9393
core.debug(`no version of gcloud matching "${version}" is installed`);
94-
await installGcloudSDK(version, skipToolCache);
94+
await installGcloudSDK(version, cache);
9595
}
9696
}
9797

0 commit comments

Comments
 (0)