Skip to content

Commit a830a94

Browse files
jasonmolendagoogle-yfyang
authored andcommitted
[lldb][objc] NSError data formatter test is failing
after PR 138209 stopped applying data formatters for T** by default, and this test expects that to work. We'll need to figure out if we want to drop this test, or adapt NSError/other objc formatters to descend an extra level or two of depth.
1 parent 3e741d9 commit a830a94

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,16 @@ def nserror_data_formatter_commands(self):
2727
"frame variable nserror", substrs=['domain: @"Foobar" - code: -1234']
2828
)
2929

30-
self.expect(
31-
"frame variable nserrorptr", substrs=['domain: @"Foobar" - code: -1234']
32-
)
30+
# The NSError data formatter will not apply to an NSError** after
31+
# https://github.com/llvm/llvm-project/pull/138209
32+
# "Add --pointer-match-depth option to type summary add command."
33+
#
34+
# Decide if we'll update the objc formatters to
35+
# dereference an additional depth level to keep this
36+
# test working, or if we should drop the behavior.
37+
#self.expect(
38+
# "frame variable nserrorptr", substrs=['domain: @"Foobar" - code: -1234']
39+
#)
3340

3441
self.expect("frame variable nserror->_userInfo", substrs=["2 key/value pairs"])
3542

0 commit comments

Comments
 (0)