Skip to content

Add default to many component properties.#746

Merged
gspencergoog merged 2 commits intogoogle:mainfrom
jgindin:component-default-values
Mar 2, 2026
Merged

Add default to many component properties.#746
gspencergoog merged 2 commits intogoogle:mainfrom
jgindin:component-default-values

Conversation

@jgindin
Copy link
Collaborator

@jgindin jgindin commented Mar 2, 2026

Description

This should help keep renderers more consistent.

Pre-launch Checklist

  • [x ] I signed the CLA.
  • [ x] I read the Contributors Guide.
  • [ x] I read the Style Guide.
  • I have added updates to the CHANGELOG.
  • [ x] I updated/added relevant documentation.
  • [ x] My code changes (if any) have tests.

This should help keep renderers more consistent.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds default values to many component properties in both the v0.9 and v0.10 JSON schemas, which will help improve consistency for renderers. The changes are generally good and align with the goal of the PR. I've found one issue in the v0.10 schema where a property was given a default but not made optional. Please see the specific comment for details.

@gspencergoog gspencergoog merged commit fd325e2 into google:main Mar 2, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants